Skip to content

Add Object.is #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 15, 2019
Merged

Add Object.is #836

merged 6 commits into from
Sep 15, 2019

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Sep 12, 2019 •
edited
Loading

DONE

@MaxGraey MaxGraey changed the title [WIP] Add Object.is Add Object.is Sep 15, 2019
@MaxGraey MaxGraey requested a review from dcodeIO September 15, 2019 00:35
@dcodeIO
Copy link
Member

dcodeIO commented Sep 15, 2019

Since the test is relatively simple and doesn't rely on runtime features, it could use an object.json specifying --runtime none.

dcodeIO
dcodeIO reviewed Sep 15, 2019
View reviewed changes
@MaxGraey
Copy link
Member Author

Done!

@dcodeIO dcodeIO merged commit 9203805 into AssemblyScript:master Sep 15, 2019
@MaxGraey MaxGraey deleted the Object-is branch September 15, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO