-
-
Notifications
You must be signed in to change notification settings - Fork 671
Interfaces, Abstract Methods, and Virtual Overloading #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 49 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
7ce5709
temp
willemneal 08f6dfe
compiles
willemneal 6b58579
Works but virtual table is hard coded
willemneal f704437
Added relooper table and if cases
willemneal 3864d7e
Fixed tests
willemneal 2904951
Update arrayEquals
willemneal e09ce14
Test email again
e58342f
Adding Email to Notice to pass test
willemneal 2a17582
Add test for structurally interface
willemneal a3aef9c
Improve type checking
willemneal 99403b8
Added error messages
willemneal 21c0227
Reduce number of unreachable instructions
willemneal e5d198c
remove file [skip ci]
willemneal 5fb758f
Remove map and iterator usage
willemneal 839aa13
Type checking improved, but virtual table needs work
099cb11
Better type checking and virtual table works
712d400
Add from to portable definition
45ba24d
Merge remote-tracking branch 'AssemblyScript/master' into virtual
b7e592b
Added Properties and Fields
694d77e
Removed virtual table function
6c29e9c
Fixed fail test
932d8ac
Add global getter example.
bec5f7c
Can handle setters
125aff0
Merge remote-tracking branch 'AssemblyScript/master' into virtual
cb4bcae
Add array.form
4c3bad9
Updated test artifacts
9f4c24b
Add Map Iterator
99721db
Added inheritance
3c813b3
Simplified and improved Inheritance
c2f72bd
Remove unneeded methods
178a3fd
Merge remote-tracking branch 'AssemblyScript/master' into virtual
7992d02
fix tests
88db597
Added Abstract Methods
b9debc4
fix uint8constructor issue
54e35d9
remove unneeded methods
3e36c26
Moved to branch table
43d9430
Added abstract SubClass to abstract method test
7e904a5
[skip ci] remove unused methods
de3d6ad
More clean up
34dba5d
Added Virtual Decorator for methods
516324d
Added more virtual overloading tests
57f6a05
update wat files
f837726
Added virtual decorator to index.d.ts
04e9672
Apparently removing comments changed the binary?
f65e9c5
Methods are virtual by default
a549360
pass linter
767124a
nits
9111134
Updates to iterators and map/set/array.from
104a573
Make Map/Set Iterable
2f58363
addresses nitpicks
cc965e3
merge passes tests
d5acd41
Merge with master
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ under the licensing terms detailed in LICENSE: | |
* Joshua Tenner <[email protected]> | ||
* Nidin Vinayakan <[email protected]> | ||
* Aaron Turner <[email protected]> | ||
* Willem Wyndham <[email protected]> | ||
* Willem Wyndham <[email protected]> or <[email protected]> | ||
* Bowen Wang <[email protected]> | ||
* Emil Laine <[email protected]> | ||
* Stephen Paul Weber <[email protected]> | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.