9.6 #340
9.6 #340
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @liyongshun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the application's AI model integrations, transitioning the embedding service to Ollama and expanding the range of supported OpenAI generator models. Concurrently, it introduces optimizations for frontend asset loading and adjusts the local development environment configuration.
Highlights
- AI Model Configuration Updates: The embedding client has been reconfigured to use Ollama instead of OpenAI, specifically utilizing the
nomic-embed-textmodel. Additionally, the OpenAI generator's default model has been updated toqwen-turbo, and support for several new Qwen models (qwen-plus,qwen-max,qwen-max-longcontext) has been added. - Frontend Performance Enhancements: Font optimization has been enabled in the Next.js configuration, and font preloading has been disabled for specific fonts (
notoSansJP,notoSerifJP,geistMono) in the application layout. - Development Environment Adjustment: The
--turbopackflag has been removed from thedevscript inpackage.json, streamlining the local development startup.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request primarily involves configuration changes, switching the embedding model to use Ollama and updating the text generation models. It also includes performance optimizations for font loading and removes the experimental Turbopack from the development script. My review identifies a significant misconfiguration where an embedding model is incorrectly listed as a text generator, which will cause issues. I've also pointed out a minor maintainability issue with a comment in a different language from the rest of the codebase.
| }, | ||
| "nomic-embed-text": { | ||
| "options": { | ||
| "temperature": 0.7, | ||
| "top_p": 0.8, | ||
| "num_ctx": 8192 | ||
| } | ||
| } |
There was a problem hiding this comment.
The model nomic-embed-text is an embedding model, not a text generation model. It is incorrectly configured here as a generator, which will likely cause errors when trying to use it for text generation. The embedder.json file is already correctly configured to use this model for embeddings. This block should be removed to fix the misconfiguration.
| @@ -33,6 +33,8 @@ const nextConfig: NextConfig = { | |||
| }; | |||
| return config; | |||
| }, | |||
| // 字体配置 | |||
There was a problem hiding this comment.
This comment is in Chinese, while the rest of the codebase appears to be in English. For consistency and to make the code easier to understand for all contributors, it's best to write comments in English.
| // 字体配置 | |
| // Font optimization configuration |
No description provided.