Skip to content

Attribute-based reverse mapping with SourceMemberAttribute #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2020
Merged

Attribute-based reverse mapping with SourceMemberAttribute #3337

merged 2 commits into from
Mar 19, 2020

Conversation

timmi-on-rails
Copy link
Contributor

@timmi-on-rails timmi-on-rails commented Feb 26, 2020 •
edited by lbargaoanu
Loading

Based on PR #3336
Added test and fix.

Fixes #3129 .
#3329

lbargaoanu
lbargaoanu reviewed Feb 27, 2020
View reviewed changes
lbargaoanu
lbargaoanu reviewed Feb 27, 2020
View reviewed changes
@lbargaoanu lbargaoanu added this to the v.next milestone Feb 27, 2020
@timmi-on-rails
Copy link
Contributor Author

Can you please trigger CI again. There seems to be an issue not related to the sourcecode

@lbargaoanu
Copy link
Contributor

It's ok, it will run again when you rebase after that other PR is merged.

@lbargaoanu
Copy link
Contributor

@timmi-on-rails Can you please rebase on master?

@timmi-on-rails
Copy link
Contributor Author

I got a conflict, when I wanted to rebase on master.
Can you work with this here?

@lbargaoanu
Copy link
Contributor

It's all your code. Surely you can solve any conflicts with your own code :)

@timmi-on-rails
Copy link
Contributor Author

Ok, I think I got it right now.

Doesn't rebasing and force pushing invalidate your code reviews, because I could make a mistake by accident (when resolving conflicts)?
I am inexperienced in rebasing across forks and extended git usage.

lbargaoanu
lbargaoanu approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@lbargaoanu lbargaoanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lbargaoanu
Copy link
Contributor

Yes, the idea is to rebase and review again. But all I'm looking the second time around is rebase errors, so it's quick. Thanks for taking the time to do everything properly. I'm sure it'll be easier next time :)

@jbogard jbogard merged commit 0189c1e into LuckyPennySoftware:master Mar 19, 2020
@timmi-on-rails timmi-on-rails deleted the issue-3129 branch March 19, 2020 13:44
@lock
Copy link

lock bot commented Apr 19, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbogard jbogard jbogard approved these changes

+1 more reviewer

@lbargaoanu lbargaoanu lbargaoanu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jbogard jbogard

Labels
Improvement
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

Attribute-based Reverse Mapping with SourceMember does not work
3 participants
@timmi-on-rails @lbargaoanu @jbogard