Skip to content

Attribute-based reverse mapping with SourceMemberAttribute #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Attribute-based reverse mapping with SourceMemberAttribute #3337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2985a0
Fixed attribute-based reverse mapping with SourceMemberAttribute
timmi-on-rails Feb 26, 2020
1ea048a
renaming
timmi-on-rails Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/AutoMapper/Configuration/MapperConfigurationExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,18 +87,20 @@ private void AddMapsCore(IEnumerable<Assembly> assembliesToScan)
{
AddProfile(type.AsType());
}

foreach (var autoMapAttribute in type.GetCustomAttributes<AutoMapAttribute>())
{
var mappingExpression = (MappingExpression) autoMapAttributeProfile.CreateMap(autoMapAttribute.SourceType, type);
autoMapAttribute.ApplyConfiguration(mappingExpression);


foreach (var memberInfo in type.GetMembers(BindingFlags.Public | BindingFlags.Instance))
{
foreach (var memberConfigurationProvider in memberInfo.GetCustomAttributes().OfType<IMemberConfigurationProvider>())
{
mappingExpression.ForMember(memberInfo, cfg => memberConfigurationProvider.ApplyConfiguration(cfg));
}
}

autoMapAttribute.ApplyConfiguration(mappingExpression);
}
}

Expand Down
76 changes: 76 additions & 0 deletions src/UnitTests/AttributeBasedMaps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,82 @@ public void Should_validate_successfully()
}
}

public class When_specifying_reverse_map_with_sourcemember_attribute : NonValidatingSpecBase
{
public class Source
{
public int Value { get; set; }
}

[AutoMap(typeof(Source), ReverseMap = true)]
public class Destination
{
[SourceMember("Value")]
public int Value2 { get; set; }
}

protected override MapperConfiguration Configuration { get; } = new MapperConfiguration(cfg =>
{
cfg.AddMaps(typeof(When_specifying_reverse_map_with_sourcemember_attribute));
});

[Fact]
public void Should_reverse_map()
{
var destination = new Destination { Value2 = 5 };
var source = Mapper.Map<Source>(destination);
source.Value.ShouldBe(5);
}

[Fact]
public void Should_validate_successfully()
{
typeof(AutoMapperConfigurationException).ShouldNotBeThrownBy(() => Configuration.AssertConfigurationIsValid(Configuration.FindTypeMapFor<Source, Destination>()));
typeof(AutoMapperConfigurationException).ShouldNotBeThrownBy(() => Configuration.AssertConfigurationIsValid(Configuration.FindTypeMapFor<Destination, Source>()));
}
}

public class When_specifying_generic_reverse_map_with_sourcemember_attribute : NonValidatingSpecBase
{
public class Source<T>
{
public T Value { get; set; }

public string StringValue { get; set; }
}

[AutoMap(typeof(Source<>), ReverseMap = true)]
public class Destination<T>
{
[SourceMember("Value")]
public int Value2 { get; set; }

[SourceMember("StringValue")]
public string StringValue2 { get; set; }
}

protected override MapperConfiguration Configuration { get; } = new MapperConfiguration(cfg =>
{
cfg.AddMaps(typeof(When_specifying_generic_reverse_map_with_sourcemember_attribute));
});

[Fact]
public void Should_reverse_map()
{
Destination<int> destination = new Destination<int> { Value2 = 5, StringValue2 = "Joe" };
Source<int> source = Mapper.Map<Source<int>>(destination);
source.Value.ShouldBe(5);
source.StringValue.ShouldBe("Joe");
}

[Fact]
public void Should_validate_successfully()
{
typeof(AutoMapperConfigurationException).ShouldNotBeThrownBy(() => Configuration.AssertConfigurationIsValid(Configuration.FindTypeMapFor(typeof(Source<>), typeof(Destination<>))));
typeof(AutoMapperConfigurationException).ShouldNotBeThrownBy(() => Configuration.AssertConfigurationIsValid(Configuration.FindTypeMapFor(typeof(Destination<>), typeof(Source<>))));
}
}

public class When_duplicating_map_configuration_with_code_and_attribute : NonValidatingSpecBase
{
public class Source
Expand Down