Forms: Try intergration api #45258
Draft
Forms: Try intergration api #45258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a centralized Integrations registry for managing form integrations, moving MailPoet integration registration from a hardcoded array to dynamic registration via the new registry. Updates initialization logic, refactors tests, and adds dedicated unit tests for the Integrations registry.
Introduces a new Integration class to encapsulate integration data. Updates Integrations::register to accept either an Integration object or array, improving flexibility. Refactors MailPoet integration registration to use the new class. Adds comprehensive unit tests for Integration and Integrations registration, including object and array handling.
Extracts inline integration components from the IntegrationsModal into separate, reusable component files. This improves code organization, maintainability, and allows for better reusability across the application. Changes: - Created ServiceIntegrationCard component for service integrations with form-specific settings support - Created PluginIntegrationCard component for plugin integrations with full state management - Updated IntegrationsModal to use hybrid approach with specific cards for known integrations and generic cards for new ones - Updated dashboard integrations to use the same hybrid pattern - Refactored both modal and dashboard to use dynamic mapping instead of hardcoded individual cards - Added proper TypeScript interfaces for component props - Maintained backward compatibility with existing specific integration components 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
| Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete. |
github-actions
bot
added
[Block] Contact Form
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
github-actions
bot
added
the
[Status] Needs Author Reply
Code Coverage SummaryCoverage changed in 4 files.
6 files are newly checked for coverage. Only the first 5 are listed here.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All integration to be extended via an
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Visit the dashboard to make see the new dummy intergreation.