Skip to content

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 24, 2025

Fixes MARMON-7

Proposed changes:

Add fallback color codes when the theme uses different codes for its colors, and presets like "Tertiary" are not available.

See the discussion in reference above for more information about the problem.

Before

image

After

Screenshot 2025-09-24 at 15 39 28

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

Note

This is good to test on a site that uses the Twenty Twenty Five theme, since that theme does not include a "Tertiary" color preset.

  • Start with a site that's connected to WordPress.com.
  • Go to Appearance > Editor > Patterns > Footer
  • Edit the footer pattern and add a Cookie Consent Block
  • Check the block's styles
    • You should see a background color set to grey.

Fixes MARMON-7

Add fallback color codes when the theme uses different codes for its colors.
@jeherve jeherve self-assigned this Sep 24, 2025
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] Low [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg Bug labels Sep 24, 2025
Copy link
Contributor

github-actions bot commented Sep 24, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/cookie-consent-block-color-fallback branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/cookie-consent-block-color-fallback

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Cookie Consent [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 24, 2025
Copy link
Contributor

github-actions bot commented Sep 24, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: October 7, 2025
    • Code freeze: October 6, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jeherve jeherve requested a review from a team September 24, 2025 13:43
Copy link

jp-launch-control bot commented Sep 24, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@jeherve jeherve added [Status] In Progress and removed [Status] Needs Review This PR is ready for review. labels Sep 24, 2025
@jeherve jeherve removed the request for review from a team September 24, 2025 13:56
@jeherve jeherve requested a review from a team September 24, 2025 14:17
@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cookie Consent Bug [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Needs Review This PR is ready for review. [Tests] Includes Tests [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant