Skip to content

fix: allow setting document array default to null #14769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: allow setting document array default to null #14769

merged 1 commit into from
Jul 29, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #6691
Re: #14717

Summary

Looks like #14717 missed a spot, we still need a change to support default: null for document arrays

Examples

IslandRhythms
IslandRhythms approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkarpov15 vkarpov15 merged commit e6918a4 into master Jul 29, 2024
@vkarpov15 vkarpov15 added this to the 8.5.2 milestone Jul 29, 2024
@hasezoey hasezoey deleted the vkarpov15/gh-6691-2 branch July 30, 2024 09:16
This was referenced Aug 21, 2024
Merged
Merged
@zntb zntb mentioned this pull request Aug 21, 2024
Merged
@issam-seghir issam-seghir mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 21, 2024
Merged
Closed
Merged
@abdoghazy2015 abdoghazy2015 mentioned this pull request Aug 21, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Aug 21, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Aug 21, 2024
Open
@tomer79sagi tomer79sagi mentioned this pull request Aug 21, 2024
Open
@Nmesoma01 Nmesoma01 mentioned this pull request Aug 21, 2024
Open
@MinhhTien MinhhTien mentioned this pull request Aug 21, 2024
Closed
@rosemondasilga rosemondasilga mentioned this pull request Aug 21, 2024
Open
@lholmquist lholmquist mentioned this pull request Aug 21, 2024
Closed
@NotZarifGithub NotZarifGithub mentioned this pull request Aug 21, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Aug 21, 2024
Open
@VarunVerma307 VarunVerma307 mentioned this pull request Aug 21, 2024
Open
@Ndi-Shema Ndi-Shema mentioned this pull request Aug 21, 2024
Open
@Chinexcee Chinexcee mentioned this pull request Aug 21, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Aug 21, 2024
Merged
@Erenkrs Erenkrs mentioned this pull request Aug 21, 2024
Open
This was referenced Sep 11, 2024
Open
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 11, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 13, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Sep 13, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 13, 2024
Open
@Tarun516 Tarun516 mentioned this pull request Sep 14, 2024
Open
@anandanshul anandanshul mentioned this pull request Sep 14, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Sep 14, 2024
Open
@McDeCoderDude McDeCoderDude mentioned this pull request Sep 14, 2024
Merged
@aviraj1703 aviraj1703 mentioned this pull request Sep 14, 2024
Open
This was referenced Sep 14, 2024
Open
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Sep 14, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 14, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Open
@thedignifiedco thedignifiedco mentioned this pull request Sep 14, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Sep 14, 2024
Open
@quangle36 quangle36 mentioned this pull request Sep 15, 2024
Open
@vky5 vky5 mentioned this pull request Sep 15, 2024
Closed
@pradumchintamani pradumchintamani mentioned this pull request Sep 15, 2024
Open
@ilovepixelart ilovepixelart mentioned this pull request Sep 15, 2024
Closed
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 15, 2024
Open
@Krithiga-Balakrishnan Krithiga-Balakrishnan mentioned this pull request Sep 16, 2024
Open
@Gehansat Gehansat mentioned this pull request Sep 16, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 16, 2024
Open
@nimren9920 nimren9920 mentioned this pull request Sep 17, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IslandRhythms IslandRhythms IslandRhythms approved these changes

@hasezoey hasezoey Awaiting requested review from hasezoey

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.5.2

Development

Successfully merging this pull request may close these issues.

Unable to set array to null as default

2 participants

@vkarpov15 @IslandRhythms