Skip to content

Minor refactor to ValidationError #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2019
Merged

Minor refactor to ValidationError #8244

merged 2 commits into from
Oct 14, 2019

Conversation

AbdelrahmanHafez
Copy link
Collaborator

Minor refactor to the ValidationError constructor, took a duplicated line out of both conditions.

vkarpov15
vkarpov15 approved these changes Oct 14, 2019
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made a minor change because the this.name = 'ValidationError' line needs to be after MongooseError.call(), because MongooseError.call() sets this.name too.

@vkarpov15 vkarpov15 added this to the 5.7.5 milestone Oct 14, 2019
@vkarpov15 vkarpov15 added the refactor This is a purely internal change for making Mongoose internals easier to understand and work with label Oct 14, 2019
@vkarpov15 vkarpov15 merged commit e6285ea into Automattic:master Oct 14, 2019
This was referenced Mar 11, 2021
Merged
Open
Open
Closed
Merged
Open
Merged
Closed
Closed
Merged
Merged
Open
Open
Closed
Closed
Open
Open
Merged
This was referenced Mar 18, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
refactor This is a purely internal change for making Mongoose internals easier to understand and work with
Projects
None yet
Milestone
5.7.5
Development

Successfully merging this pull request may close these issues.
3 participants
@AbdelrahmanHafez @vkarpov15 @dskrvk