-
Notifications
You must be signed in to change notification settings - Fork 3
Filter users #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter users #70
Conversation
Is there any plan supporting |
I don't think so. What do you think @jkmassel? |
Interesting – I guess you might just want the Does that work? Have you tested it against the API? |
@jkmassel It looks like it does - at least for creating users. Would you like me to implement it? |
We should support it eventually, but I'd say put it on the backlog for now – returning a whole By the time we're doing |
I've created a separate issue for that: #74. |
Addresses #29.
This PR implements fields based filtering for
/users
endpoint, includinglist
,retrieve
andretrieve_me
variants. It adds aSparseUserField
enum and 3 new request builders that take a slice of these fields.It adds quite a few integration tests using
rstest
, but it takes less than a second to run all of them, and they give us the peace of mind that filtering is working as expected, so I think it's well worth it.Note that all tests use the
Edit
context as they test every single field type and not all fields are available for all contexts. We could add specific tests forEmbed
&View
contexts, but I am not sure there is too much value in that. Let me know what you think!