Adds PluginSlug & PluginWpOrgDirectorySlug
#91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
crazytonyli
approved these changes
May 21, 2024
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do you mind adding some docs (similar to your PR description) to these two types?
There was a problem hiding this comment.
Not at all, but do you mind if that happens as part of the general documentation effort that's scheduled in the next milestone-ish?
I am not sure about the format yet, so I don't want to add a random one at the moment. However, be assured that everything public will have documentation soon 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #90.
As explained in #90, there are two different plugin slugs and if we use
Stringtype for both, they'll be easy to mix up. The PR introducesPluginSlug&PluginWpOrgDirectorySlugtypes to address the issue.Note that we don't use the new type pattern for this, because new type pattern will allow passing the original type as a valid value, making it less effective. I think we might even want to make
UserIdto be a proper type to avoid this issue - although withUserIdit's more of a heads up to developers rather than a guard against a practical issue. So, I could see an argument for using the new type pattern for those cases.To Test
make test-server && make dump-mysql && make backup-wp-content-pluginscargo test --test '*' -- --nocapture --test-threads 1