-
Notifications
You must be signed in to change notification settings - Fork 815
[#1125] Introduce SagaLifecycle.associationValues()
#2141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposal is nice, let's make an actual implementation out of this.
Be sure to:
- Update the copyright notices
- Provide a usable implementation
- Add documentation to the methods that may be used by contributors. This includes
protected
methods for when a user constructs their own impl. - Add tests!
modelling/src/main/java/org/axonframework/modelling/saga/SagaLifecycle.java
Outdated
Show resolved
Hide resolved
modelling/src/main/java/org/axonframework/modelling/saga/SagaLifecycle.java
Show resolved
Hide resolved
modelling/src/main/java/org/axonframework/modelling/saga/SagaLifecycle.java
Show resolved
Hide resolved
SagaLifecycle.associationValues()
…ifecycle.java Co-authored-by: Steven van Beelen <[email protected]>
@smcvb What do you mean by "Provide a usable implementation". It is usable as it is here, it was that simple. The methods were already there, it just needed to be added to the I will tidy up and write some tests to make it a good PR. |
Kudos, SonarCloud Quality Gate passed! |
You got me here. This shows I don't know all code from Framework on top of my mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concerns have been addressed, hence approving.
Proposal for adding a method to the
SagaLifecycle
, based on this discuss question.This PR will resolve #1125.