Add test for ConsistentHash.equals #2244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcvb
added
Priority 4: Would
smcvb
requested changes
Jun 7, 2022
There was a problem hiding this comment.
First and foremost, thanks for the contribution, @lacinoire! Any form of help we receive, albeit issues, comments, or PRs like yours, is very much appreciated. If you're up for doing more, we would gladly receive them.
Now, I do have a couple of rather detailed comments on your test. Let me know what you think 👍
messaging/src/test/java/org/axonframework/commandhandling/distributed/ConsistentHashTest.java
Outdated
Show resolved
Hide resolved
messaging/src/test/java/org/axonframework/commandhandling/distributed/ConsistentHashTest.java
Outdated
Show resolved
Hide resolved
messaging/src/test/java/org/axonframework/commandhandling/distributed/ConsistentHashTest.java
Outdated
Show resolved
Hide resolved
smcvb
approved these changes
Jun 8, 2022
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 😊
I want to contribute the following test:
Test that
consistentHashModified.equals(new ConsistentHash())is false whenequalsis called with the parametero = new ConsistentHash().This tests the method
ConsistentHash.equals.This test is based on the test
testConflictingHashesDoNotImpactMembership.Curious to hear what you think!
(I wrote this test as part of a research study at TU Delft. Find out more)