-
Notifications
You must be signed in to change notification settings - Fork 6
proof of note creation #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
type = "contract" | ||
|
||
[dependencies] | ||
aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v0.87.9", directory = "noir-projects/aztec-nr/aztec" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this to work with the latest testnet version, 2.0.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have updated everything to work with latest testnet version !
note-send-proof/circuits/Nargo.toml
Outdated
|
||
[dependencies] | ||
aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v0.87.9", directory = "noir-projects/aztec-nr/aztec" } | ||
uint_note = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v0.87.9", directory = "noir-projects/aztec-nr/uint-note" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be updated to 2.0.3 as well?
note-send-proof/scripts/package.json
Outdated
"lint": "eslint ." | ||
}, | ||
"dependencies": { | ||
"@aztec/accounts": "0.87.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, but its working! this is super cool and will be a great reference 🙏
aztec-up @ 2.0.3 | ||
|
||
Steps: | ||
1. aztec-nargo compile in circuits/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you wrap the commands in backticks (`) so that they show up as code blocks? it makes it more clear
This proves note hash delivery | ||
|
||
Prerequisites: | ||
aztec-up @ 2.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a link to the docs on how to install aztec-up
@@ -0,0 +1,16 @@ | |||
This proves note hash delivery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some more context. Why would someone want to do this? It might be helpful to explain the question that instigated the development of this example.
1. aztec-nargo compile in circuits/ | ||
2. aztec-nargo compile in sample-contract | ||
3. aztec-postprocess-contract in sample-contract | ||
4. yarn codegen in scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4. yarn codegen in scripts | |
4. `yarn && yarn codegen` in ./scripts |
5. aztec start --sandbox in terminal 2 | ||
6. yarn start in scripts | ||
7. copy details outputted by step 6 | ||
8. yarn dev in vite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8. yarn dev in vite | |
8. `yarn && yarn dev` in ./vite |
4. yarn copy-target in scripts | ||
5. aztec start --sandbox in terminal 2 | ||
6. yarn start in scripts | ||
7. copy details outputted by step 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where am i supposed to copy this? continuing through, I see its meant to be copy pasted in the web app, but that isnt clear at this point
Also i see the output in my terminal like this:

Can you log it in a way that makes it easier to copy-paste? as is, when i double click on the value it highlights this whole line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh 1 more thing, can you create a CI test for this? It may be helpful to look at how its done for aztec-starter https://github.com/AztecProtocol/aztec-starter/tree/main/.github/workflows |
Workflow
things needed to know