Skip to content

Adding settings to Function App in Bicep templates. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 30, 2022
Merged

Adding settings to Function App in Bicep templates. #83

merged 4 commits into from
May 30, 2022

Conversation

willvelida
Copy link

Purpose

  • ...

This PR has been raised in response to issue #75. This PR contains the following changes:

  • Extending the main.bicep file to differentiate settings for each function based on the following documentation.
  • Adding parameter descriptions in all Bicep files.
  • Adding Cosmos DB secrets to the provisioned Key Vault.

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

wviriya
wviriya reviewed May 30, 2022
View reviewed changes
Copy link
Contributor

@wviriya wviriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wviriya wviriya merged commit 9c136fb into refresh-functions-v4 May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wviriya wviriya wviriya left review comments

@DanielLarsenNZ DanielLarsenNZ Awaiting requested review from DanielLarsenNZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willvelida @wviriya