Skip to content

Fix missing configs in package.json for Modular and RLC #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025
Merged

Fix missing configs in package.json for Modular and RLC #3215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
611e31e
fix missing configs in package.json for Modular and RLC
kazrael2119 May 27, 2025
cf27ac5
update
kazrael2119 May 27, 2025
e3a16fc
revert changes
kazrael2119 May 27, 2025
fc357f4
merge main
kazrael2119 May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/autorest.typescript/test/smoke/generated/agrifood-data-plane/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/autorest.typescript/test/smoke/generated/anomaly-detector-mv-rest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/autorest.typescript/test/smoke/generated/anomaly-detector-rest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/autorest.typescript/test/smoke/generated/purview-administration-rest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
7 changes: 6 additions & 1 deletion packages/rlc-common/src/metadata/packageJson/packageCommon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,12 @@ function getEsmEntrypointInformation(config: PackageCommonInfoConfig) {
return;
}

return { tshy: getTshyConfig(config), type: "module" };
return {
tshy: getTshyConfig(config),
type: "module",
browser: "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js"
};
}

export function getTshyConfig(config: PackageCommonInfoConfig) {
Expand Down
18 changes: 18 additions & 0 deletions packages/rlc-common/test/integration/packageJson.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,24 @@ describe("Package file generation", () => {
"pnpm pack 2>&1"
);
});

it("should include browser and react-native in package.json", () => {
const model = createMockModel({
...baseConfig,
azureArm: true,
isModularLibrary: true
});
const packageFileContent = buildPackageFile(model);
const packageFile = JSON.parse(packageFileContent?.content ?? "{}");

expect(packageFile).to.have.property(
"browser", "./dist/browser/index.js",
);
expect(packageFile).to.have.property(
"react-native", "./dist/react-native/index.js"
);

});
});

describe("Azure flavor for standalone library", () => {
Expand Down
2 changes: 2 additions & 0 deletions ...est/test/NetworkAnalytics.Management/generated/typespec-ts/sdk/test/arm-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/ai/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/anomalyDetector/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/authoring/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/batch_modular/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/chatApi_modular/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/confidentialLedger/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/contentsafety_modular/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/contoso/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/customWrapper/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/faceai/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions ...es/typespec-test/test/healthInsights_radiologyinsights/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/healthInsights_trialmatcher/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/hierarchy_generic/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/loadTest/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/loadtesting_modular/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/nestedClient/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/openai/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/openai_generic/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/openai_modular/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/openai_non_branded/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"scripts": {
"clean": "rimraf --glob dist dist-browser dist-esm test-dist temp types *.tgz *.log",
"extract-api": "rimraf review && mkdirp ./review && api-extractor run --local",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/overloads_modular/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/parametrizedHost/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/schemaRegistry/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/spread/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/todo_non_branded/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"scripts": {
"clean": "rimraf --glob dist dist-browser dist-esm test-dist temp types *.tgz *.log",
"extract-api": "rimraf review && mkdirp ./review && api-extractor run --local",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/translator/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-test/test/widget_dpg/generated/typespec-ts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
"selfLink": false
},
"type": "module",
"browser": "./dist/browser/index.js",
"react-native": "./dist/react-native/index.js",
"keywords": [
"node",
"azure",
Expand Down
Loading