This repository was archived by the owner on Jan 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Fix 90 updating manifest djob #138
Open
amrasem
wants to merge
13
commits into
Azure:master
Choose a base branch
from
amrasem:fix-90-updating-manifest-djob
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync between master and forked branch_1712
Azadehkhojandi
suggested changes
Dec 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting PR, great idea of using Databricks Reset on updates.
I put few comments on the files and also could you please add test to cover your update manifest fix?
Extended databricks operator to report metrics into Prometheus (Azure#104)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Azadehkhojandi
suggested changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, I have updated my comments.
* dashboard configmap added * moved the Grafana docs to own section * updated the docs for installing grafana dashboard
27f707a
to
09fd8ec
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is about updating current djob with new value for instance updating the notebook path, It doesn't update the notebook path
To reproduce the issue:
Create a djob
Update the notebook path
It doesn't update the notebook path but shows the successful message.