Skip to content

Add DurableClient class declaration #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 8, 2023

Conversation

hossam-nasr
Copy link
Contributor

@hossam-nasr hossam-nasr commented Feb 1, 2023

Resolves #154, part of #416. Adds a DurableClient class declaration that the DurableOrchestrationClient class implements, and exports it from the root of the package.

// before
const client = df.getClient(context)
// client. -> no intellisense

// after
const client: DurableClient = df.getClient(context);
// client. -> all the intellisense ✨

@hossam-nasr hossam-nasr changed the title Add DurableClient interface Add DurableClient class declaration Feb 8, 2023
@hossam-nasr hossam-nasr force-pushed the hossamnasr/durableClientInterface branch from b0242fb to 91456f6 Compare February 8, 2023 02:38
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. From the discussion, it would appear we are ok with this change.

@hossam-nasr hossam-nasr force-pushed the hossamnasr/durableClientInterface branch from 72ab679 to c028bcf Compare February 8, 2023 23:18
@hossam-nasr hossam-nasr merged commit c8314e7 into v3.x Feb 8, 2023
@hossam-nasr hossam-nasr deleted the hossamnasr/durableClientInterface branch February 8, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants