-
Notifications
You must be signed in to change notification settings - Fork 56
Export class declarations from the types
directory
#470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
reviewed
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR mostly makes sense. Just a question at this time.
ejizba
reviewed
Feb 8, 2023
ejizba
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the nit about the message?
thing left, but otherwise LGTM
This was referenced Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prelude to #458, part of #416. This PR adds class declarations exported from the root of the package (living in the
types
directory), for relevant public-facing classes. Specifically, it exports declarations for the following classes:PurgeHistoryResult
EntityStateResponse
HttpManagementPayload
EntityId
DurableOrchestrationStatus
RetryOptions
ManagedIdentityTokenSource
AggregatedError
DurableError
DummyOrchestrationContext
DummyEntityContext
Furthermore, it also moves the
OrchestrationRuntimeStatus
enum to theorchestrationTypes
file.