Skip to content

Export class declarations from the types directory #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 8, 2023

Conversation

hossam-nasr
Copy link
Contributor

@hossam-nasr hossam-nasr commented Feb 8, 2023

Prelude to #458, part of #416. This PR adds class declarations exported from the root of the package (living in the types directory), for relevant public-facing classes. Specifically, it exports declarations for the following classes:

  • PurgeHistoryResult
  • EntityStateResponse
  • HttpManagementPayload
  • EntityId
  • DurableOrchestrationStatus
  • RetryOptions
  • ManagedIdentityTokenSource
  • AggregatedError
  • DurableError
  • DummyOrchestrationContext
  • DummyEntityContext

Furthermore, it also moves the OrchestrationRuntimeStatus enum to the orchestrationTypes file.

Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR mostly makes sense. Just a question at this time.

Copy link
Contributor

@ejizba ejizba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the nit about the message? thing left, but otherwise LGTM

@hossam-nasr hossam-nasr merged commit 6ae8535 into v3.x Feb 8, 2023
@hossam-nasr hossam-nasr deleted the hossamnasr/exportTypes branch February 8, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants