Strip query params with no value #3789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocav
approved these changes
Nov 17, 2018
fabiocav
reviewed
Nov 17, 2018
| foreach (var pair in request.Query) | ||
| { | ||
| http.Query.Add(pair.Key, pair.Value.ToString()); | ||
| if (!string.IsNullOrEmpty(pair.Value.ToString())) |
There was a problem hiding this comment.
Value here should never actually be null here, though.
|
@mhoeger - Can you please add test for this? |
mhoeger
force-pushed
the
rpcNullValues
branch
from
bc8a183 to
f3a3299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Azure/azure-functions-nodejs-worker#142
However, we need a better and more complete implementation of this, as an empty query is value is valid. Note that this is also an issue with null value'd HTTP headers.