-
Notifications
You must be signed in to change notification settings - Fork 64
Introduce new TypedData types #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new TypedData types #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor comments. Mostly looks good. Thanks!
endtoendtests/Azure.Functions.Java.Tests.E2E/Azure.Functions.Java.Tests.E2E/Constants.cs
Outdated
Show resolved
Hide resolved
endtoendtests/Azure.Functions.Java.Tests.E2E/Azure.Functions.Java.Tests.E2E/Constants.cs
Outdated
Show resolved
Hide resolved
endtoendtests/Azure.Functions.Java.Tests.E2E/Azure.Functions.Java.Tests.E2E/Constants.cs
Outdated
Show resolved
Hide resolved
...ests/Azure.Functions.Java.Tests.E2E/Azure.Functions.Java.Tests.E2E/EventHubsEndToEndTests.cs
Outdated
Show resolved
Hide resolved
endtoendtests/src/main/java/com/microsoft/azure/functions/endtoend/EventHubTriggerTests.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/RpcCollectionDoubleDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/RpcCollectionDoubleDataSource.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/handler/WorkerInitRequestHandler.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/azure/functions/worker/binding/tests/Utility.java
Outdated
Show resolved
Hide resolved
@amamounelsayed - Please pull in the changes from proto file release: https://github.com/Azure/azure-functions-language-worker-protobuf/tree/v1.3.0-protofile |
@pragnagopa Based on the changed we did in the host we handle the list of string as collections. For example before when we have array of string we deal with is as list of Json. Now we will return it back as list of string and it is up to the user to handle the content in the way they like. Referring to convertToStringArrayOrList should not be called anymore with the new updates. |
- Support CollectionSting, CollectionLong, CollectionDouble, CollectionByte[]
Add tests for CollectionString, CollectionDouble, CollectionLong, CollectionByte[]
…e-worker-protobuf. Tag: v1.3.1-protofile. Commit: 9da87c9f1958c18ff38ce3bba7581c9bd88f8dc0
31073c5
to
4479c13
Compare
endtoendtests/src/main/java/com/microsoft/azure/functions/endtoend/EventHubTriggerTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few questions on tests. Rest looks good. Thanks!
- Support CollectionSting, CollectionLong, CollectionDouble, CollectionByte[]
Add tests for CollectionString, CollectionDouble, CollectionLong, CollectionByte[]
…e-worker-protobuf. Tag: v1.3.1-protofile. Commit: 9da87c9f1958c18ff38ce3bba7581c9bd88f8dc0
…amounelsayed/azure-functions-java-worker into fix/eventhub-many-cardinality
Closing in favor of #316 |
Fixes Java runtime with Event hub, Binary datatype and Cardinality many #297