Skip to content

Introduce new TypedData types #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

amamounelsayed
Copy link
Contributor

@amamounelsayed amamounelsayed commented Jul 16, 2019

Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments. Mostly looks good. Thanks!

@pragnagopa
Copy link
Member

@pragnagopa
Copy link
Member

@amamounelsayed
Copy link
Contributor Author

amamounelsayed commented Jul 24, 2019

@pragnagopa Based on the changed we did in the host we handle the list of string as collections. For example before when we have array of string we deal with is as list of Json. Now we will return it back as list of string and it is up to the user to handle the content in the way they like. Referring to convertToStringArrayOrList should not be called anymore with the new updates.

@amamounelsayed amamounelsayed force-pushed the fix/eventhub-many-cardinality branch from 31073c5 to 4479c13 Compare July 24, 2019 17:41
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few questions on tests. Rest looks good. Thanks!

pragnagopa
pragnagopa previously approved these changes Jul 25, 2019
@pragnagopa
Copy link
Member

Closing in favor of #316

@pragnagopa pragnagopa closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java runtime with Event hub, Binary datatype and Cardinality many
2 participants