Skip to content

Remove signatures in-place from AppInsights agent jar before adding it to worker package #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

ahmedmuhsin
Copy link
Contributor

Update the packaging script to avoid the need to extract the complete JAR before removing the signature files. Instead of extracting the JAR, we now remove the signature files in-place by using a zip utility. This change reduces the time taken to package the worker and also reduces the disk space required to extract the JAR.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@ahmedmuhsin ahmedmuhsin merged commit 701f380 into Azure:dev Feb 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants