Create setErrorMessage function #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
reviewed
Jun 19, 2024
ejizba
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for Exception: Cannot set property message of [object Object] which has only a getter.
In February, we merged an earlier fix for this same issue (#732).
However, @ryanbecker reported a problem with our initial approach.
Therefore, we have rolled back those changes and instead take a simpler approach. Everywhere we previously tried to write to
error.message, we now catch any exceptions thrown by read-only errors. In those cases, we simply return the original error and do not attempt to modify its error message.