Skip to content

OpenAI skill trigger/Return value from pipeline #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

andystaples
Copy link
Contributor

@andystaples andystaples commented Jan 22, 2025

Return a value for assistantSkillTrigger similar to Durable Activities

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@andystaples andystaples requested a review from AnatoliB January 22, 2025 22:14
@andystaples andystaples marked this pull request as ready for review January 22, 2025 22:14
@andystaples andystaples changed the title WIP - OpenAI skill trigger/Return value from pipeline OpenAI skill trigger/Return value from pipeline Jan 22, 2025
@andystaples
Copy link
Contributor Author

TODO: Discuss documentation, release notes, potential side-effects, parity w/ other ooproc langs

- Ensure pipeline output is not logged for assistantSkillTrigger
Copy link
Contributor

@AnatoliB AnatoliB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not right now, but if we need to make changes in this area in the future (perhaps adding yet another exception for other triggers): we should probably extract all the places controlling the return value and tracing behavior to a separate class, so we don't have to search for these places again and can just add one more trigger to the list. LGTM for now though.

@andystaples andystaples merged commit 9c1d4cf into dev Feb 7, 2025
7 checks passed
@andystaples andystaples deleted the andystaples/return-for-openai-skill-trigger branch February 7, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants