Skip to content

Improve dependency management logs #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2019
Merged

Improve dependency management logs #354

merged 5 commits into from
Oct 11, 2019

Conversation

AnatoliB
Copy link
Contributor

Improve dependency management logs:

  • For every dependency snapshot installation start, success, or failure event, log the installation mode as well ("Required" vs. "Optional").
  • Log AcceptableFunctionAppDependenciesAlreadyInstalled just once on worker start, no need to repeat it later.

Francisco-Gamino
Francisco-Gamino approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the detailed comments.

@AnatoliB AnatoliB merged commit 91cfab4 into Azure:dev Oct 11, 2019
@AnatoliB AnatoliB deleted the improve-dependency-management-logs branch October 11, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Francisco-Gamino Francisco-Gamino Francisco-Gamino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnatoliB @Francisco-Gamino