Skip to content

Use int.MaxValue for gRPC message size limit #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Use int.MaxValue for gRPC message size limit #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Messaging/MessagingStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ internal class MessagingStream
private readonly AsyncDuplexStreamingCall<StreamingMessage, StreamingMessage> _call;
private readonly SemaphoreSlim _semaphoreSlim = new SemaphoreSlim(initialCount: 1, maxCount: 1);

internal MessagingStream(string host, int port, int maxMessageLength)
internal MessagingStream(string host, int port)
{
const int maxMessageLength = int.MaxValue;

var channelOptions = new []
{
new ChannelOption(ChannelOptions.MaxReceiveMessageLength, maxMessageLength),
Expand Down
4 changes: 2 additions & 2 deletions src/Worker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public async static Task Main(string[] args)
.WithParsed(ops => arguments = ops)
.WithNotParsed(err => Environment.Exit(1));

var msgStream = new MessagingStream(arguments.Host, arguments.Port, arguments.MaxMessageLength);
var msgStream = new MessagingStream(arguments.Host, arguments.Port);
var requestProcessor = new RequestProcessor(msgStream);

// Send StartStream message
Expand Down Expand Up @@ -62,7 +62,7 @@ internal class WorkerArguments
[Option("requestId", Required = true, HelpText = "Request ID used for gRPC communication with the Host.")]
public string RequestId { get; set; }

[Option("grpcMaxMessageLength", Required = true, HelpText = "gRPC Maximum message size.")]
[Option("grpcMaxMessageLength", Required = false, HelpText = "[Deprecated and ignored] gRPC Maximum message size.")]
public int MaxMessageLength { get; set; }
}
}