Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
reviewed
Nov 24, 2021
src/RequestProcessor.cs
Outdated
| @@ -97,6 +97,7 @@ internal StreamingMessage ProcessWorkerInitRequest(StreamingMessage request) | |||
| { | |||
| var workerInitRequest = request.WorkerInitRequest; | |||
| Environment.SetEnvironmentVariable("AZUREPS_HOST_ENVIRONMENT", $"AzureFunctions/{workerInitRequest.HostVersion}"); | |||
| Environment.SetEnvironmentVariable("POWERSHELL_DISTRIBUTION_CHANNEL", $"Azure-Functions-{workerInitRequest.HostVersion}"); | |||
There was a problem hiding this comment.
I think a colon works better as a separator as that's what we use in our MSI
Suggested change
| Environment.SetEnvironmentVariable("POWERSHELL_DISTRIBUTION_CHANNEL", $"Azure-Functions-{workerInitRequest.HostVersion}"); | |
| Environment.SetEnvironmentVariable("POWERSHELL_DISTRIBUTION_CHANNEL", $"Azure-Functions:{workerInitRequest.HostVersion}"); |
There was a problem hiding this comment.
Sounds good. Code updated.
Francisco-Gamino
added a commit
that referenced
this pull request
Nov 29, 2021
* Add POWERSHELL_DISTRIBUTION_CHANNEL env variable * Update environment variable value format
7 tasks
Francisco-Gamino
added a commit
that referenced
this pull request
Nov 29, 2021
* Add POWERSHELL_DISTRIBUTION_CHANNEL env variable * Update environment variable value format
7 tasks
Francisco-Gamino
added a commit
that referenced
this pull request
Nov 29, 2021
Francisco-Gamino
added a commit
that referenced
this pull request
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Add POWERSHELL_DISTRIBUTION_CHANNEL environment variable
Pull request checklist
release_notes.mdAdditional information
Additional PR information