Patch Stop-DurableOrchestration #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
changed the title
|
Just a friendly ping on this one @Francisco-Gamino, @michaelpeng36 |
Francisco-Gamino
approved these changes
Sep 26, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 29, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 29, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 29, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 29, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #640
The Terminate API demands a POST request instead of a GET method invoke. This PR ensures we're making the right HTTP request, and re-enables the test that was meant to catch this incompatibility. It seems most users manually utilize the HTTP endpoints to terminate orchestrations, which is probably why this error was not caught before.
Pull request checklist
release_notes.mdAdditional information
Additional PR information