feat: Adding support for Starlette Request and Responses #104

vrdmr · 2025-03-21T15:10:40Z

No description provided.

Copilot

Pull Request Overview

This PR adds support for Starlette Request and Response types to the Azure Functions extensions by creating new packaging, implementation, and test files. Key changes include:

Adding a new pyproject.toml for packaging the Starlette-based extension.
Implementing the core HTTP extension functionality in the azurefunctions/extensions/http/starlette directory.
Adding tests and updating package initialization files.

Reviewed Changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
azurefunctions-extensions-http-starlette/pyproject.toml	Introduces packaging configuration for the new Starlette extension.
azurefunctions-extensions-http-starlette/tests/init.py	Sets up the test bootstrap for the extension.
azurefunctions-extensions-http-starlette/README.md	Provides user documentation, though it currently contains inconsistencies with naming.
azurefunctions-extensions-http-starlette/azurefunctions/extensions/http/starlette/init.py	Exposes Starlette-based request/response and web server classes.
azurefunctions-extensions-http-starlette/tests/test_web.py	Contains tests for the web module and synchronization functionality.
azurefunctions-extensions-http-starlette/azurefunctions/extensions/http/starlette/web.py	Implements the core functionality for Starlette based request/response handling and server setup.
azurefunctions-extensions-http-starlette/azurefunctions/extensions/http/init.py, azurefunctions-extensions-http-starlette/azurefunctions/init.py, azurefunctions-extensions-http-starlette/azurefunctions/extensions/init.py	Package initializations using pkgutil to extend package paths.

Files not reviewed (2)

azurefunctions-extensions-http-starlette/LICENSE: Language not supported
azurefunctions-extensions-http-starlette/MANIFEST.in: Language not supported

Comments suppressed due to low confidence (4)

azurefunctions-extensions-http-starlette/README.md:1

The header incorrectly references a FastApi library; please update it to 'Starlette' to match the PR's purpose.

# Azure Functions Extensions Http FastApi library for Python

azurefunctions-extensions-http-starlette/README.md:4

The source code link points to the FastApi extension repository; update the URL to reference the Starlette extension repository.

[Source code](https://github.com/Azure/azure-functions-python-extensions/tree/main/azurefunctions-extensions-http-fastapi)

azurefunctions-extensions-http-starlette/README.md:20

The package name in the requirements should be updated to 'azurefunctions-extensions-http-starlette' to reflect the actual extension implemented.

3. Add ```azurefunctions-extensions-http-fastapi``` to your requirements.txt

azurefunctions-extensions-http-starlette/README.md:21

Update the import statement to use azurefunctions.extensions.http.starlette instead of fastapi so that it aligns with the new implementation.

4. Import Request and different types of responses from ```azurefunctions.extensions.http.fastapi``` in your HttpTrigger functions.

Copilot · 2025-03-21T15:11:31Z

azurefunctions-extensions-http-starlette/README.md

+| [Samples](hhttps://github.com/Azure/azure-functions-python-extensions/tree/main/azurefunctions-extensions-http-fastapi/samples)
+


There is a typo in the URL ('hhttps'); it should be corrected to 'https'.

Suggested change

| [Samples](hhttps://github.com/Azure/azure-functions-python-extensions/tree/main/azurefunctions-extensions-http-fastapi/samples)

| [Samples](https://github.com/Azure/azure-functions-python-extensions/tree/main/azurefunctions-extensions-http-fastapi/samples)

hallvictoria · 2025-03-31T16:42:26Z

azurefunctions-extensions-http-starlette/README.md

@@ -0,0 +1,74 @@
+# Azure Functions Extensions Http FastApi library for Python


Please update the FastApi references to Starlette as well as any other Starlette specific README changes

hallvictoria · 2025-03-31T16:43:47Z

azurefunctions-extensions-http-starlette/azurefunctions/extensions/http/starlette/__init__.py

+    "FileResponse"
+]
+
+__version__ = "0.0.1b1"


Version can be 1.0.0b1

hallvictoria · 2025-03-31T16:45:41Z

azurefunctions-extensions-http-starlette/pyproject.toml

+[project]
+name = "azurefunctions-extensions-http-starlette"
+dynamic = ["version"]
+requires-python = ">=3.10"


FastAPI supports 3.8+. Is there a reason starlette has to be 3.10+?

hallvictoria · 2025-03-31T16:46:14Z

azurefunctions-extensions-http-starlette/pyproject.toml

+    ]
+dependencies = [
+        'azurefunctions-extensions-base',
+        'azure-functions',


Can azure-functions be removed as a dependency?

hallvictoria · 2025-03-31T16:51:55Z

azurefunctions-extensions-http-starlette/tests/test_web.py

+        self.assertEqual(
+            ResponseTrackerMeta.get_response_type(ResponseLabels.FILE),
+            StarletteFileResponse,
+        )


Please add a test_code_quality.py test file

hallvictoria · 2025-03-31T16:53:07Z

azurefunctions-extensions-http-starlette/tests/__init__.py

+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
+
+"""Bootstrap for '$ python setup.py test' command."""


This line is legacy from using setup.py -- it can be removed

hallvictoria · 2025-03-31T16:54:47Z

azurefunctions-extensions-http-starlette/tests/test_web.py

+        self.assertEqual(
+            ResponseTrackerMeta.get_response_type(ResponseLabels.FILE),
+            StarletteFileResponse,
+        )


Please update the pipelines to run these tests. You will need a ci-starlette-test.yml file under eng/ci and a starlette-unit-tests.yml file under eng/templates/official/jobs

hallvictoria · 2025-03-31T16:55:58Z

azurefunctions-extensions-http-starlette/tests/test_web.py

+        self.assertEqual(
+            ResponseTrackerMeta.get_response_type(ResponseLabels.FILE),
+            StarletteFileResponse,
+        )


Once the extension is published on PyPI, a samples directory will also need to be added

hallvictoria · 2025-03-31T16:56:58Z

azurefunctions-extensions-http-starlette/azurefunctions/extensions/http/starlette/__init__.py

@@ -0,0 +1,24 @@
+__path__ = __import__("pkgutil").extend_path(__path__, __name__)


Please remove this

hallvictoria · 2025-03-31T16:57:55Z

azurefunctions-extensions-http-starlette/pyproject.toml

@@ -0,0 +1,54 @@
+[build-system]
+requires = ["setuptools >= 61.0", "wheel"]


Is wheel also needed here?

hallvictoria · 2025-03-31T16:58:58Z

azurefunctions-extensions-http-starlette/pyproject.toml

+    'pytest-instafail',
+    'pre-commit',
+    'isort',
+    'black'


Can you also add flake8 and mypy here? Those are used for our code quality tests

hallvictoria · 2025-03-31T16:59:58Z

azurefunctions-extensions-http-starlette/tests/test_web.py

@@ -0,0 +1,225 @@
+import asyncio


Please add the copyright text to the top of this

vrdmr added 3 commits March 20, 2025 18:13

Adding Starlette MCP PyWorker Extension

f6e0b70

Renamed to MCP server

621118e

Renamed files and cleaned up

ad82185

vrdmr requested review from gavin-aguiar and hallvictoria as code owners March 21, 2025 15:10

vrdmr requested review from Copilot, hallvictoria and gavin-aguiar and removed request for hallvictoria and gavin-aguiar March 21, 2025 15:10

Copilot AI reviewed Mar 21, 2025

View reviewed changes

Merge branch 'dev' into vameru/starlette-web-api

6a455cf

hallvictoria reviewed Mar 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Adding support for Starlette Request and Responses #104

feat: Adding support for Starlette Request and Responses #104

Uh oh!

vrdmr commented Mar 21, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 21, 2025

Uh oh!

hallvictoria Mar 31, 2025 •

edited

Loading

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

hallvictoria Mar 31, 2025

Uh oh!

Uh oh!

		\| [Samples](hhttps://github.com/Azure/azure-functions-python-extensions/tree/main/azurefunctions-extensions-http-fastapi/samples)

	\| [Samples](hhttps://github.com/Azure/azure-functions-python-extensions/tree/main/azurefunctions-extensions-http-fastapi/samples)
	\| [Samples](https://github.com/Azure/azure-functions-python-extensions/tree/main/azurefunctions-extensions-http-fastapi/samples)

		@@ -0,0 +1,74 @@
		# Azure Functions Extensions Http FastApi library for Python

		@@ -0,0 +1,24 @@
		__path__ = __import__("pkgutil").extend_path(__path__, __name__)

		@@ -0,0 +1,54 @@
		[build-system]
		requires = ["setuptools >= 61.0", "wheel"]

feat: Adding support for Starlette Request and Responses #104

Are you sure you want to change the base?

feat: Adding support for Starlette Request and Responses #104

Uh oh!

Conversation

vrdmr commented Mar 21, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

hallvictoria Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hallvictoria Mar 31, 2025 •

edited

Loading