Skip to content

fix: 1.0.0a4: update version and revert abcmoduletrackermeta bug #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@
"RequestSynchronizer",
]

__version__ = "1.0.0a2"
__version__ = "1.0.0a6"
Original file line number Diff line number Diff line change
Expand Up @@ -125,21 +125,17 @@ def check_type(cls, pytype: type) -> bool:
return False


class ABCModuleTrackerMeta(abc.ABCMeta, ModuleTrackerMeta):
pass


class WebApp(metaclass=ABCModuleTrackerMeta):
class WebApp(metaclass=ModuleTrackerMeta):
@abstractmethod
def route(self, func: Callable):
raise NotImplementedError()

@abstractmethod
def get_app(self):
raise NotImplementedError()
raise NotImplementedError() # pragma: no cover


class WebServer(metaclass=ABCModuleTrackerMeta):
class WebServer(metaclass=ModuleTrackerMeta):
def __init__(self, hostname, port, web_app: WebApp):
self.hostname = hostname
self.port = port
Expand Down
2 changes: 1 addition & 1 deletion azure-functions-extension-base/tests/test_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def test_decode_typed_data(self):

# Case 7: attempt to coerce and pass
datum_coerce_pass = meta.Datum(value=1, type="model_binding_data")
self.assertEquals(
self.assertEqual(
meta._BaseConverter._decode_typed_data(datum_coerce_pass, python_type=str),
"1",
)
Expand Down
30 changes: 6 additions & 24 deletions azure-functions-extension-base/tests/test_web.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,36 +354,18 @@ async def serve(self):
self.assertEqual(server.port, 8080)
self.assertEqual(server.web_app, "MockApp")

async def test_serve_method_raises_not_implemented_error(self):
# Create a mock WebApp instance
class MockWebApp(WebApp):
def route(self, func):
pass

def get_app(self):
pass

class MockWebServer(WebServer):
async def serve(self):
super().serve()

# Create a WebServer instance with the mock WebApp
server = MockWebServer("localhost", 8080, MockWebApp())
class TestHttpV2Enabled(unittest.TestCase):
def test_http_v2_enabled(self):
ModuleTrackerMeta._module = None

# Ensure that calling the serve method raises NotImplementedError
with self.assertRaises(NotImplementedError):
await server.serve()
class MockClass(metaclass=ModuleTrackerMeta):
pass

MockClass()

class TestHttpV2Enabled(unittest.TestCase):
@patch("azure.functions.extension.base.ModuleTrackerMeta.module_imported")
def test_http_v2_enabled(self, mock_module_imported):
mock_module_imported.return_value = True
self.assertTrue(HttpV2FeatureChecker.http_v2_enabled())

mock_module_imported.return_value = False
self.assertFalse(HttpV2FeatureChecker.http_v2_enabled())


class TestResponseLabels(unittest.TestCase):
def test_enum_values(self):
Expand Down
Loading