Skip to content

Check if deferred bindings is enabled in base ext #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Mar 18, 2024

Adds a method in the base extension that will replace the following worker check.

if (SDK_BINDING_REGISTRY is not None
            and SDK_BINDING_REGISTRY.check_supported_type(pytype)):

Instead, this check will look like:

if check_deferred_bindings_enabled(sdk_binding_registry=SDK_BINDING_REGISTRY, pytype=pytype):

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@4f5699c). Click here to learn what that means.

Files Patch % Lines
...ension-base/azure/functions/extension/base/meta.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev       #4   +/-   ##
======================================
  Coverage       ?   86.39%           
======================================
  Files          ?       28           
  Lines          ?      992           
  Branches       ?      119           
======================================
  Hits           ?      857           
  Misses         ?      121           
  Partials       ?       14           
Flag Coverage Δ
unittests 86.39% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria changed the title check if deferred bindings is enabled in base Check if deferred bindings is enabled in base ext Mar 18, 2024
@hallvictoria hallvictoria marked this pull request as ready for review March 18, 2024 21:37
@hallvictoria hallvictoria merged commit a9ecfc0 into dev Mar 19, 2024
@hallvictoria hallvictoria deleted the hallvictoria/check_db_enabled branch April 24, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants