Skip to content

Addressing PR comments #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Addressing PR comments #6

merged 1 commit into from
Mar 19, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Mar 19, 2024

  • renamed base tests
  • removed unused imports
  • updated version and python version classifiers

@hallvictoria hallvictoria marked this pull request as ready for review March 19, 2024 19:40
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (a9ecfc0) to head (d646017).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev       #6      +/-   ##
==========================================
- Coverage   86.39%   86.36%   -0.03%     
==========================================
  Files          28       28              
  Lines         992      990       -2     
  Branches      119      119              
==========================================
- Hits          857      855       -2     
  Misses        121      121              
  Partials       14       14              
Flag Coverage Δ
unittests 86.36% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria merged commit ba33bc5 into dev Mar 19, 2024
@hallvictoria hallvictoria deleted the hallvictoria/base-comments branch April 24, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants