Skip to content

Mark python-dateutil as install required #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2022

Conversation

YunchuWang
Copy link
Member

Description

Linux consumption tests are failing as module 'python-dateutil' not found error happening in #1004. The cause is current mesh image is installing worker deps from released worker version instead of setup.py from local or pr branch. We will also update linux consumption test to use v4 images so this change will be taken into runtime image.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1021 (24a76fa) into dev (5e5d250) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 24a76fa differs from pull request most recent head 042d9e5. Consider uploading reports for the commit 042d9e5 to get more accurate results

@@            Coverage Diff             @@
##              dev    #1021      +/-   ##
==========================================
- Coverage   82.88%   82.77%   -0.11%     
==========================================
  Files          33       33              
  Lines        1776     1765      -11     
  Branches      282      282              
==========================================
- Hits         1472     1461      -11     
  Misses        234      234              
  Partials       70       70              
Flag Coverage Δ
unittests 82.77% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/dispatcher.py 89.09% <0.00%> (-0.03%) ⬇️
azure_functions_worker/extension.py 99.06% <0.00%> (-0.02%) ⬇️
azure_functions_worker/constants.py 100.00% <0.00%> (ø)
...ed_memory_data_transfer/shared_memory_constants.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5d250...042d9e5. Read the comment docs.

@YunchuWang YunchuWang changed the title Wangbill/mark dateutil required Mark python-dateutil as install required May 6, 2022
@YunchuWang YunchuWang changed the base branch from v3.x-dev to dev May 6, 2022 16:33
@YunchuWang YunchuWang requested a review from pdthummar as a code owner May 6, 2022 16:33
@YunchuWang YunchuWang merged commit 300fc05 into dev May 10, 2022
@YunchuWang YunchuWang deleted the wangbill/mark-dateutil-required branch May 10, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants