Skip to content

Enabled dependency isolation by default #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 22, 2022
Merged

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Jun 7, 2022

Description

Enabling dependency isolation by default for all python versions.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1055 (d2af1f4) into dev (b582f2b) will decrease coverage by 51.31%.
The diff coverage is 83.33%.

❗ Current head d2af1f4 differs from pull request most recent head bab4d2d. Consider uploading reports for the commit bab4d2d to get more accurate results

@@             Coverage Diff             @@
##              dev    #1055       +/-   ##
===========================================
- Coverage   83.09%   31.78%   -51.32%     
===========================================
  Files          33       33               
  Lines        1775     1762       -13     
  Branches      282      282               
===========================================
- Hits         1475      560      -915     
- Misses        232     1201      +969     
+ Partials       68        1       -67     
Flag Coverage Δ
unittests 31.78% <83.33%> (-51.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/utils/dependency.py 32.57% <80.00%> (-53.90%) ⬇️
azure_functions_worker/constants.py 100.00% <100.00%> (ø)
azure_functions_worker/functions.py 23.72% <0.00%> (-72.32%) ⬇️
azure_functions_worker/dispatcher.py 19.14% <0.00%> (-69.98%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
azure_functions_worker/extension.py 43.92% <0.00%> (-55.16%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-54.91%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b582f2b...bab4d2d. Read the comment docs.

@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/dep_iso_stein branch from 592f0ee to 450fe63 Compare June 8, 2022 19:49
@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/dep_iso_stein branch from 0b0250a to d9f9ef6 Compare June 8, 2022 23:03
@gavin-aguiar gavin-aguiar marked this pull request as ready for review June 8, 2022 23:03
@YunchuWang YunchuWang force-pushed the gaaguiar/dep_iso_stein branch from d9f9ef6 to 1da42b3 Compare June 14, 2022 18:29
@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/dep_iso_stein branch from c17d89d to 1af2e2d Compare June 15, 2022 18:54
@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/dep_iso_stein branch from b436bcc to 4bd58a5 Compare June 20, 2022 15:24
@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/dep_iso_stein branch from 94c6394 to a076422 Compare June 20, 2022 15:52
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/dep_iso_stein branch from 0e4ba93 to bab4d2d Compare June 21, 2022 23:48
@gavin-aguiar gavin-aguiar merged commit b1085b5 into dev Jun 22, 2022
@gavin-aguiar gavin-aguiar deleted the gaaguiar/dep_iso_stein branch June 22, 2022 14:24
YunchuWang pushed a commit that referenced this pull request Aug 23, 2022
YunchuWang added a commit that referenced this pull request Aug 23, 2022
* Revert "Enabled dependency isolation by default (#1055)"

This reverts commit b1085b5.

* Enable dependency isolation for python 3.10 by default

* fix dep isolation python 3.10 unit tests

* add copyright to dependency.py

Co-authored-by: peterstone2017 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants