Skip to content

docker test fix #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2023
Merged

docker test fix #1184

merged 6 commits into from
Feb 27, 2023

Conversation

gavin-aguiar
Copy link
Contributor

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1184 (d2def81) into dev (df5d5b5) will decrease coverage by 51.99%.
The diff coverage is n/a.

❗ Current head d2def81 differs from pull request most recent head 716bdce. Consider uploading reports for the commit 716bdce to get more accurate results

@@             Coverage Diff             @@
##              dev    #1184       +/-   ##
===========================================
- Coverage   83.90%   31.92%   -51.99%     
===========================================
  Files          34       34               
  Lines        1889     1889               
  Branches      363      276       -87     
===========================================
- Hits         1585      603      -982     
- Misses        233     1285     +1052     
+ Partials       71        1       -70     
Flag Coverage Δ
unittests 31.92% <ø> (-51.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_functions_worker/bindings/nullable_converters.py 21.62% <0.00%> (-78.38%) ⬇️
azure_functions_worker/functions.py 25.00% <0.00%> (-71.28%) ⬇️
azure_functions_worker/dispatcher.py 19.74% <0.00%> (-69.24%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-57.85%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
azure_functions_worker/extension.py 44.95% <0.00%> (-54.13%) ⬇️
azure_functions_worker/utils/dependency.py 33.08% <0.00%> (-53.39%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gavin-aguiar gavin-aguiar marked this pull request as ready for review February 27, 2023 16:57
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavin-aguiar gavin-aguiar merged commit dd88338 into dev Feb 27, 2023
@gavin-aguiar gavin-aguiar deleted the gaaguiar/docker_test_fix branch February 27, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants