-
Notifications
You must be signed in to change notification settings - Fork 108
SettingsApi ModuleNotFoundError fix when extensions enabled #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
59ba143
ModuleNotFound error fix when extensions is enabled
2bf3688
Fixed flake8 errors
b0c472a
Fixed flake8 validation
3031641
Fixed unit tests
5f7e1b6
Addressed comments
081c89d
Fixed log formatiting
a7f4eac
Fixed flake8 validation
fcc178b
Removed debug logging check from unittest
84a953f
Added py311 tests for TPTC
b17e282
Skipped TestThreadPoolSettingsPython38 for py37
e721111
Fixed flake8 validation
4fe8b28
Updated threadpool tests
9bca926
Test unit tests failures
82cb42c
Fixing unit tests failures
d517cc3
Added exception message to test case
8c0343c
Fixed logging error
23b6ea7
Addressed comments
f43860f
Address comments
e449ff5
Fixed unit tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -217,14 +217,37 @@ def test_pinning_functions_to_older_version(self): | |
"AzureWebJobsStorage": self._storage, | ||
"SCM_RUN_FROM_PACKAGE": self._get_blob_url( | ||
"PinningFunctions"), | ||
"PYTHON_ISOLATE_WORKER_DEPENDENCIES": "1" | ||
"PYTHON_ISOLATE_WORKER_DEPENDENCIES": "1", | ||
}) | ||
req = Request('GET', f'{ctrl.url}/api/HttpTrigger1') | ||
resp = ctrl.send_request(req) | ||
|
||
self.assertEqual(resp.status_code, 200) | ||
self.assertIn("Func Version: 1.11.1", resp.text) | ||
|
||
@skipIf(sys.version_info.minor != 10, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want the same for 3.9? and see what the experience is? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not needed. It should have the same behavior since extensions is enabled in this test. |
||
"This is testing only for python310") | ||
def test_opencensus_with_extensions_enabled(self): | ||
"""A function app with extensions enabled containing the | ||
following libraries: | ||
|
||
azure-functions, azure-eventhub, azure-storage-blob, numpy, | ||
cryptography, pyodbc, requests | ||
|
||
should return 200 after importing all libraries. | ||
""" | ||
with LinuxConsumptionWebHostController(_DEFAULT_HOST_VERSION, | ||
self._py_version) as ctrl: | ||
ctrl.assign_container(env={ | ||
"AzureWebJobsStorage": self._storage, | ||
"SCM_RUN_FROM_PACKAGE": self._get_blob_url("Opencensus"), | ||
"PYTHON_ENABLE_WORKER_EXTENSIONS": "1", | ||
"AzureWebJobsFeatureFlags": "EnableWorkerIndexing" | ||
}) | ||
req = Request('GET', f'{ctrl.url}/api/opencensus') | ||
resp = ctrl.send_request(req) | ||
self.assertEqual(resp.status_code, 200) | ||
|
||
def _get_blob_url(self, scenario_name: str) -> str: | ||
return ( | ||
f'https://pythonworker{self._py_shortform}sa.blob.core.windows.net/' | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.