Moved dateutil to install_requires #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-aguiar
requested review from
vrdmr,
YunchuWang,
pdthummar and
hallvictoria
as code owners
hallvictoria
approved these changes
Mar 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1443 +/- ##
=======================================
Coverage 85.10% 85.10%
=======================================
Files 35 35
Lines 1974 1974
Branches 374 374
=======================================
Hits 1680 1680
Misses 218 218
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YunchuWang
pushed a commit
that referenced
this pull request
Mar 11, 2024
* Moved dateutil to install_requires * Flake8 fixes
YunchuWang
added a commit
that referenced
this pull request
Mar 11, 2024
* Moved dateutil to install_requires (#1443) * Moved dateutil to install_requires * Flake8 fixes * Update Python Worker Version to 4.26.0 --------- Co-authored-by: gavin-aguiar <[email protected]> Co-authored-by: AzureFunctionsPython <[email protected]>
hallvictoria
added a commit
that referenced
this pull request
Apr 11, 2024
* sdk working prototype * misc * new registry pseudo * prototype changes * weird dispatcher changes * almost works * working prototype!! * reset flag * support for mix & match in same func * added pytype to decode() * caching * added tests * revert later * lint, clean up, templates * reorder * reorder again * test pypi problems * correct dir * checking tests * 404s * investigating 500s * no cache * debugging * more helpful debugging * check raw bindings * runtime error * runtime error logging attempt * local logger * sys modules * typo * extensions version * testing changes -- revert later * added host logs * spacing? * debugging changes * Moved dateutil to install_requires (#1443) * Moved dateutil to install_requires * Flake8 fixes * Update Python Worker Version to 4.26.0 * net8 target framework * stdout is not none * tests pass locally * updating extension versions * temp table test fix * table and eventhub test fix * all blob tests * merge with dev * no importlib * specific tests only for deferred bindings * removed -e * syntax * ignore test, add back in cache * revert eh and table tests * blob extension resources * >=3.9 support + test fixes * lint * removed testing changes * lint again * unit tests fix * append to list * fixes + tests * reset flag, extra test * revert meta changes, tests passing locally * fixed tests * fix unit test, import by default * revert default import, meta refactoring * fixed meta refactor * added tests for helpers * type syntax * fixed tests * actually fixed tests * update base ext supported python version * fixing unit test timeouts? * setup.py too * installing from .[deferred-bindings] * update base ext supported python version again * update var name in setup.py * update var name in meta * refactor tests into sep folder * lint + install only .NET6 * remove script * edit workflow * import by default, misc fixes * revert, only changed var name * get_binding check * revert get_binding check, import by default * lint * rename, replace None checks, comments * fixed flag placement * attribute error + lint * fixed unit tests * yml bug/feature reports * moving flag set out of get_binding * lint + 100 * add registry none check * lint * move check * revert error raise * changed order * revert flag set * loader registry none check * adding back in checks * reports & workflow feedback * permissions + consumption * feedback * setup.py * db test csproj * remove 3.12 * combined db & e2e test workflow * fixed consumption workflow * fixed 3.7 tests * skip all tests * renamed registries as constants * add flag as part of FunctionInfo + tests * lint * added logs (fails until new base) * lint + base update * changing bind_name (fails until exts) * Revert "changing bind_name (fails until exts)" This reverts commit 7971498. * is_db property added to PTI * fixed test * quick log * better log * lint * refactor FI + pin pip * return cache val immediately * install .[test-db] only for >=3.9 * fixing installation * fixing installation pt2 * fixing installation pt3 * sep step for installations * sep step for installations pt2 * closed if + semicolon * updated refs to base * updated refs to blob (rerun later) * update setup.py * remove import try/catch * log bug fix * unit tests * pin pip * log if base not found * log delimiters * removed f strings * lint + feedback * pydocs + default val * get_raw_bindings method * var names + docs --------- Co-authored-by: gavin-aguiar <[email protected]> Co-authored-by: AzureFunctionsPython <[email protected]> Co-authored-by: Victoria Hall <[email protected]> Co-authored-by: wangbill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had moved dateutils to extra requires in the previous PR thinking it was only used in tests. Its actually used in datumdef.py.
Moving it back to install requires
Fixes #
PR information
Quality of Code and Contribution Guidelines