Setting special limits for Python 3.[6|7] #890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Python 3.6 and 3.7, setting max workers to large values is problematic as the implementation of ThreadPoolExecutor for both that versions do not reuse threads until max_workers number is hit, and that is a danger to the functioning of the app. This PR limits the number of max_workers to 32 for 3.6 and 3.7 and allows it to be
sys.maxint
for Python 3.8+.Reference doc - ThreadPoolExecutor
Fixes #873
PR information
Quality of Code and Contribution Guidelines