Skip to content

Added e2e tests for dependency isolation #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2021
Merged

Added e2e tests for dependency isolation #919

merged 4 commits into from
Dec 3, 2021

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Nov 30, 2021 •
edited
Loading

Description

Added the following e2e tests for dependency isolation

  • When customer has an older az func version
  • When customer has a new az func version
  • Minor changes to grpc and protobuf e2e tests

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@gavin-aguiar gavin-aguiar requested a review from vrdmr as a code owner November 30, 2021 02:07
@gavin-aguiar gavin-aguiar marked this pull request as draft November 30, 2021 02:07
@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/dep_iso_e2e_tests branch from c244898 to 360630b Compare November 30, 2021 02:32
@gavin-aguiar gavin-aguiar marked this pull request as ready for review November 30, 2021 02:52
vrdmr
vrdmr approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit changes requested. Once you make the changes, please go ahead and merge the PR.

LGTM

@gavin-aguiar gavin-aguiar merged commit 2bc45d1 into dev Dec 3, 2021
@gavin-aguiar gavin-aguiar deleted the gaaguiar/dep_iso_e2e_tests branch December 3, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrdmr vrdmr vrdmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavin-aguiar @vrdmr