-
Notifications
You must be signed in to change notification settings - Fork 65
PowerShell NULL and function file updates #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9ccbeb5
fix mac integration tools path and test with new ps worker function
VasuBhog cda655c
add back empty string unstable test
VasuBhog d37b1c8
fix powershell integration tests
VasuBhog 5eb8ca2
add sdk to use dotnet 6 for test
VasuBhog 45c0979
Merge branch 'main' into vabhog/fixMacTesting
VasuBhog c2b3a99
check dotnet version via pipeline
VasuBhog 8599416
update pipeline and null case test
VasuBhog 06fabe7
add console logs
VasuBhog b45231f
use triggerMetadata instead of Request
VasuBhog 97f58bd
update values to unsupported for unstable tests
VasuBhog 5563955
update all powershell funcs to include triggermetadata
VasuBhog 72cf294
Merge branch 'main' into vabhog/fixMacTesting
VasuBhog 4671e85
Merge branch 'main' into vabhog/fixMacTesting
VasuBhog fbd8815
remove mac brew find path
VasuBhog e8ce426
Merge branch 'main' into vabhog/fixMacTesting
VasuBhog 886f087
address comments
VasuBhog 947e9d7
address comments and add unsupported
VasuBhog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
samples/samples-powershell/AddProductWithIdentityColumn/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
samples/samples-powershell/AddProductWithIdentityColumnIncluded/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
samples/samples-powershell/AddProductWithMultiplePrimaryColumnsAndIdentity/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
samples/samples-powershell/AddProductsWithIdentityColumnArray/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
samples/samples-powershell/GetProductsStoredProcedureFromAppSetting/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,8 +47,8 @@ public void AddProductTest(int id, string name, int cost, SupportedLanguages lan | |
[SqlInlineData(1, "Test", 5)] | ||
[SqlInlineData(0, "", 0)] | ||
[SqlInlineData(-500, "ABCD", 580)] | ||
// Currently PowerShell and Java functions return null when the parameter for name is an empty string | ||
// Issue link: https://github.com/Azure/azure-functions-sql-extension/issues/443 | ||
// Currently Java functions return null when the parameter for name is an empty string | ||
// Issue link: https://github.com/Azure/azure-functions-sql-extension/issues/517 | ||
[UnsupportedLanguages(SupportedLanguages.PowerShell, SupportedLanguages.Java)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are still failing for Java it seems. @lucyzhang929 - possibly a similar issue for their worker. So something to follow up with them about when you get around to investigating this. |
||
public void AddProductParamsTest(int id, string name, int cost, SupportedLanguages lang) | ||
{ | ||
|
@@ -116,7 +116,7 @@ public void AddProductArrayTest(SupportedLanguages lang) | |
[SqlInlineData()] | ||
// This test is currrently failing in the Linux pipeline for Java | ||
// https://github.com/Azure/azure-functions-sql-extension/issues/521 | ||
[UnsupportedLanguages(SupportedLanguages.Java)] | ||
[UnsupportedLanguages(SupportedLanguages.Java, SupportedLanguages.PowerShell)] | ||
public void AddProductColumnTypesTest(SupportedLanguages lang) | ||
{ | ||
this.StartFunctionHost(nameof(AddProductColumnTypes), lang, true); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/Integration/test-powershell/AddProductExtraColumns/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/Integration/test-powershell/AddProductMissingColumns/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/Integration/test-powershell/AddProductMissingColumnsExceptionFunction/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/Integration/test-powershell/AddProductsNoPartialUpsert/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/Integration/test-powershell/GetProductsColumnTypesSerialization/run.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.