Fix mac integration function tools path #533
Conversation
VasuBhog
requested review from
Charles-Gagnon,
lucyzhang929,
chlafreniere and
MaddyDev
as code owners
| @@ -265,6 +265,20 @@ private static string GetFunctionsCoreToolsPath() | |||
| } | |||
| throw new FileNotFoundException($"Azure Function Core Tools not found at {funcPath} or {programFilesFuncPath}"); | |||
| } | |||
| else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX)) | |||
There was a problem hiding this comment.
Does OSPlatform only has OSX for mac? Just making sure that it's inclusive for macos11/12/etc
There was a problem hiding this comment.
There seems to be FreeBSD, Linux, OSX, Windows, and Create OS as options for OSPlatform.
I believe that OSX should be inclusive of any version of Mac.
Co-authored-by: Charles Gagnon <[email protected]>
|
@VasuBhog I tried pulling down the branch, had a connection string that used SQL Auth, and got an error about kerberos: Is this a known issue? |
https://github.com/Azure/azure-functions-sql-extension/tree/main/test - setting SA Password for local connection string or Test_Connection_String for Azure SQL Connections should be done prior to running dotnet test |
Ah, user error, didn't have the SA_PASSWORD environment variable set. |
* fix mac integration function tools path * Update test/Integration/IntegrationTestBase.cs
If users on Mac have Azure Function core tools installed via Brew. Then dotnet test will constantly fail.