Enable AddProductParam test for Python #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
chlafreniere and
MaddyDev
as code owners
MaddyDev
approved these changes
Jan 9, 2023
|
There was a linting error on the file, otherwise looks good! |
| import azure.functions as func | ||
| from Common.product import Product | ||
|
|
||
| def main(req: func.HttpRequest, product: func.Out[func.SqlRow]) -> func.HttpResponse: | ||
| row = func.SqlRow(Product(req.params["productId"], req.params["name"], req.params["cost"])) | ||
| # The Python worker discards empty query parameters so use parse_qs as a workaround. |
There was a problem hiding this comment.
Should we document this somewhere or is this just temporary (is the Python worker going to change this behavior?)
There was a problem hiding this comment.
Waiting on the Python worker team's response on the issue Azure/azure-functions-python-worker#894
Charles-Gagnon
approved these changes
Jan 9, 2023
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* enable AddProductParam test for Python * fix linting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the workaround mentioned in this issue Azure/azure-functions-python-worker#894 to get the empty string query parameter.