Fixed a bug to continue visting NextPageLink when listing key vaults from ARM API #17618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethanyZhou
force-pushed
the
bez/keyvault
branch
from
4c5f033 to
d06f4df
Compare
BethanyZhou
force-pushed
the
bez/keyvault
branch
from
d06f4df to
8cdd3f7
Compare
|
/azp run azure-powershell - powershell-core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-powershell - windows-powershell |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BethanyZhou
force-pushed
the
bez/keyvault
branch
from
8cdd3f7 to
5d1cbc8
Compare
isra-fel
requested changes
Mar 28, 2022
| @@ -18,7 +18,8 @@ | |||
| - Additional information about change #1 | |||
| --> | |||
| ## Upcoming Release | |||
|
|
|||
| * Fixed a bug to continue visting `NextPageLink` when listing key vaults from ARM API | |||
There was a problem hiding this comment.
No bug id, this issue is reported by email
| { | ||
| IResourceManagementClient armClient = ResourceClient; | ||
|
|
||
| return new GenericPageEnumerable<GenericResource>(() => armClient.Resources.List(filter), armClient.Resources.ListNext, first, skip).Select(r => new PSKeyVaultIdentityItem(r)); | ||
| var response = armClient.Resources.List(filter); |
There was a problem hiding this comment.
Refactor to avoid duplicated code
There was a problem hiding this comment.
Introduce a new method
ListPagable(Func<type of response> getFirstPage, Func<string, type of response> getNextPage)
Then you can simplify these two methods to call ListPagable
There was a problem hiding this comment.
Refactored without delegate function as the signature of Resources.List(filter) and ResourceGroup.ListResources(resourcegroupName, filter) is different.
isra-fel
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added