Skip to content

Add new cmdlets for AzureDataTransfer #27926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 69 commits into
base: main
Choose a base branch
from

Conversation

fzkhan
Copy link
Member

@fzkhan fzkhan commented Jun 11, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@fzkhan
Copy link
Member Author

fzkhan commented Jun 15, 2025

@vidai-msft I have renamed it to DataTransfer. But:

  • I still don't see the file you mentioned. Here is the exact list of steps I went through:
docker run -it -v Z:\Repos\azure-powershell\src:/src autorest
cd DataTransfer/DataTransfer.Autorest
autorest --reset
autorest README.md
pwsh ./build-module.ps1
pwsh ./run-module.ps1
  • I cannot run tests now as I am facing the same error as mentioned in these two threads (thread 1, thread 2). I am not using a local swagger, and I am running this command after running all of the commands I mentioned above: pwsh ./test-module.ps1 -Live
    Error for reference:
PS /src/DataTransfer/DataTransfer.Autorest [Az.DataTransfer]> pwsh ./test-module.ps1 -Live
Creating isolated process...
Installing local Pester module into '/src/DataTransfer/DataTransfer.Autorest/generated/modules'...
Get-Item: /src/DataTransfer/DataTransfer.Autorest/test-module.ps1:44
Line |
  44 |  … ModulePSD = Get-Item -Path (Join-Path $HOME '.PSSharedModules\Resourc …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path '/root/.PSSharedModules/Resources/Az.Resources.TestSupport.psd1' because it does not exist.

@fzkhan
Copy link
Member Author

fzkhan commented Jun 16, 2025

@vidai-msft Able to get around the testing failure now. Please let me know how to generate the file as I still am not able to get the commands to output it.

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@fzkhan
Copy link
Member Author

fzkhan commented Jun 17, 2025

Formatting of examples is not correct and output is missing:

image

@vidai-msft
Copy link
Contributor

Formatting of examples is not correct and output is missing:

image

@fzkhan Where did you see the output? From PowerShell console or markdown file?

@fzkhan
Copy link
Member Author

fzkhan commented Jun 17, 2025

@vidai-msft This is from the PS window after running ./run-module.ps1 :

image

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@fzkhan fzkhan requested a review from vidai-msft June 18, 2025 11:26
@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants