Skip to content

Add Teams CallDetails custom context support #49784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 20, 2025
Merged

Add Teams CallDetails custom context support #49784

merged 11 commits into from
May 20, 2025

Conversation

v-vkaluri
Copy link
Contributor

  • Updated SDK to include Teams CallDetails in custom calling context
  • Added SetTeamsPhoneCallDetails method to CustomCallContext
  • Implemented conversion between public and internal models
  • Added comprehensive unit tests for all CallAutomation APIs

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

azure-sdk commented May 1, 2025 •
edited by github-actions bot
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.Communication.CallAutomation

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Communication.CallAutomation

@v-vkaluri v-vkaluri force-pushed the users/v-vkaluri/feature/teamsCallContext branch from c204dfe to bda2149 Compare May 2, 2025 01:05
ajaych-ms
ajaych-ms approved these changes May 20, 2025
View reviewed changes
@v-vkaluri v-vkaluri marked this pull request as ready for review May 20, 2025 22:03
@v-vkaluri v-vkaluri requested a review from v-dharmarajv May 20, 2025 22:05
@v-vkaluri v-vkaluri enabled auto-merge (squash) May 20, 2025 22:52
@v-vkaluri v-vkaluri merged commit 5b74ccd into main May 20, 2025
20 checks passed
@v-vkaluri v-vkaluri deleted the users/v-vkaluri/feature/teamsCallContext branch May 20, 2025 22:53
ajaykumarmehra pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request May 23, 2025
@v-vkaluri @ajaykumarmehra
Add Teams CallDetails custom context support (Azure#49784)
8b950d3 
* Add Teams CallDetails custom context support

* Updated the CallConnectionTests

* Make all properties in TeamsPhone*Details classes publicly settable

* Adding a null check for internalEvent.CustomEvent in case of non Pstn events

* Updatng the Incoming Call Context null check

* Added the Teams Call Context in Incoming Call

* Updated the TeamsPhoneCallDetails and TeamsPhoneSourceDetails public constructors

* Update Models to accept TeamsPhoneCallDetails and add helper to convert to internal format

* Addressed the PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaych-ms ajaych-ms ajaych-ms approved these changes

@minwoolee-msft minwoolee-msft minwoolee-msft approved these changes

@v-dharmarajv v-dharmarajv Awaiting requested review from v-dharmarajv

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-vkaluri @azure-sdk @ajaych-ms @minwoolee-msft @v-dharmarajv