Radiology insights ga #35276

koen-mertens · 2024-04-19T06:44:11Z

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

.\venv\Scripts\activate pip install -r dev_requirements.txt pip install tox<5 pip install -e . adjustments sample_critical_result_inference_async

fixes pylint

…ertens/azure-sdk-for-python into radiology-insights-GA-cb3

Radiology insights ga cb3

Radiology insights ga

azure-sdk · 2024-04-19T07:17:28Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-healthinsights-radiologyinsights

Update cspell file & fix some unknown words for typos

xiangyan99 · 2024-05-06T14:46:24Z

/azp run python - codeowners-linter - ci

azure-pipelines · 2024-05-06T14:46:33Z

Azure Pipelines successfully started running 1 pipeline(s).

...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py

catalinaperalta

looking good, just a few small fixes

...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py

...hinsights-radiologyinsights/azure/healthinsights/radiologyinsights/aio/_operations/_patch.py

...althinsights/azure-healthinsights-radiologyinsights/samples/sample_age_mismatch_inference.py

...sights/azure-healthinsights-radiologyinsights/samples/sample_age_mismatch_inference_async.py

...althinsights/azure-healthinsights-radiologyinsights/samples/sample_age_mismatch_inference.py

...zure-healthinsights-radiologyinsights/samples/sample_complete_order_discrepancy_inference.py

sdk/healthinsights/ci.yml

- remove unused imports in patch.py - resolve duplicate references in models.py - resolve duplicate and wrong references in README.md

cbovijn

Fix causes issues.

...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py

...althinsights/azure-healthinsights-radiologyinsights/samples/sample_age_mismatch_inference.py

- move imports in samples - fix pylint and mypy issues in patch files

replace deserialize with job iso inference result

- fix bugs sample_laterality_discrepancy_inference.py - adjust _operations

replace deserialize Job with InferenceResult

...insights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_operations.py

- replace with expected code in _patch

fix mypy error in _patch.py (add ignore)

catalinaperalta

Some samples were overlooked during the clean up process fyi

...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py

...sights/azure-healthinsights-radiologyinsights/samples/sample_sex_mismatch_inference_async.py

...althinsights/azure-healthinsights-radiologyinsights/samples/sample_sex_mismatch_inference.py

...azure-healthinsights-radiologyinsights/samples/sample_radiology_procedure_inference_async.py

...ights/azure-healthinsights-radiologyinsights/samples/sample_radiology_procedure_inference.py

adjust sample_radiology_procedure_inference to align with the other samples adjust sample_radiology_procedure_inference_async to align with the other samples adjust sample_sex_mismatch_inference to align with the other samples adjust sample_sex_mismatch_inference_async to align with the other samples

* Update tsp-location.yaml with latest commit id * regenerated SDK .\venv\Scripts\activate pip install -r dev_requirements.txt pip install tox<5 pip install -e . adjustments sample_critical_result_inference_async * inference * Adjusted README.md * adjustment tests fixes pylint * fix get result call on inferences inside job * implementation RadiologyInsightsInferenceResult in samples and tests * removed headers from test files * cspell updates & fix typos Update cspell file & fix some unknown words for typos * fix tests in record mode * fix spelling errors * fix spelling error * Update sample_finding_inference.py * Update sample_finding_inference.py * fix reviewer comments * add breaking changes to changelog and fix pylint issue * Update assets.json * Regenerated SDK for authentication, adjusted samples * Update CHANGELOG.md * fixing PR conversations * small cosmetic changes * Update README.md * refactor sample and adjust changelog * Update sample_age_mismatch_inference_async.py * adjust async samples according to review * Update README.md * fix tests for other packages * Update assets.json * Update assets.json * Update assets.json * regenerated SDK * disable healthinsights tests * disable cancerprofiling and trialmatcher test * disable tests * remove key based authentication from samples and documentation * fix tests * push recordings to assets * change sync to async cred * remove credentials sample and update documentation * Update sdk/healthinsights/azure-healthinsights-radiologyinsights/README.md Co-authored-by: catalinaperalta <[email protected]> * Update sdk/healthinsights/azure-healthinsights-radiologyinsights/README.md Co-authored-by: catalinaperalta <[email protected]> * change samples and add a patch method * adjust tests * fix tests for radiology insights * - adjust def documentation in patch.py - remove unused imports in patch.py - resolve duplicate references in models.py - resolve duplicate and wrong references in README.md * - fix exception handling in samples - move imports in samples - fix pylint and mypy issues in patch files * remove class from sync samples replace deserialize with job iso inference result * - fix bugs sample_finding_inference.py - fix bugs sample_laterality_discrepancy_inference.py - adjust _operations * undo changes in patch files : replace deserialize Job with InferenceResult * - revert changes in _operations - replace with expected code in _patch * postprocess changes * revert _patch * fix pylint error in _operations.py fix mypy error in _patch.py (add ignore) * move ignore comment in _patch.py adjust sample_radiology_procedure_inference to align with the other samples adjust sample_radiology_procedure_inference_async to align with the other samples adjust sample_sex_mismatch_inference to align with the other samples adjust sample_sex_mismatch_inference_async to align with the other samples --------- Co-authored-by: cbovijn <[email protected]> Co-authored-by: Celia Bovijn <[email protected]> Co-authored-by: catalinaperalta <[email protected]>

koen-mertens and others added 16 commits April 4, 2024 21:20

Update tsp-location.yaml with latest commit id

26e01cb

Merge branch 'Azure:main' into radiology-insights-GA

e11803e

Merge branch 'Azure:main' into radiology-insights-GA

cf679d9

Merge branch 'Azure:main' into radiology-insights-GA

fcbaa81

Merge branch 'Azure:main' into radiology-insights-GA-cb3

7baea53

regenerated SDK

e933941

.\venv\Scripts\activate pip install -r dev_requirements.txt pip install tox<5 pip install -e . adjustments sample_critical_result_inference_async

inference

a936e3f

Adjusted README.md

3487bb6

adjustment tests

324a1bb

fixes pylint

fix get result call on inferences inside job

b47628e

Merge branch 'radiology-insights-GA-cb3' of https://github.com/koen-m…

a39586c

…ertens/azure-sdk-for-python into radiology-insights-GA-cb3

implementation RadiologyInsightsInferenceResult in samples and tests

9202e58

removed headers from test files

8bee798

Merge branch 'Azure:main' into radiology-insights-GA

f0a3ab2

Merge pull request #1 from koen-mertens/radiology-insights-GA-cb3

38a9659

Radiology insights ga cb3

Merge pull request #2 from koen-mertens/radiology-insights-GA

8fc344b

Radiology insights ga

github-actions bot added the Cognitive - Health Insights label Apr 19, 2024

koen-mertens and others added 4 commits April 20, 2024 00:01

cspell updates & fix typos

f447f8b

Update cspell file & fix some unknown words for typos

Merge branch 'Azure:main' into radiology-insights-GA

249e64b

fix tests in record mode

0a82ebf

fix spelling errors

a58e5ba

koen-mertens and others added 3 commits May 6, 2024 17:21

Merge branch 'Azure:main' into radiology-insights-GA

74d360f

fix spelling error

7c47022

Update sample_finding_inference.py

190e983

koen-mertens marked this pull request as ready for review May 6, 2024 19:40

koen-mertens requested a review from tomsft as a code owner May 6, 2024 19:40

Update sample_finding_inference.py

5fe8770

koen-mertens added 2 commits July 16, 2024 00:35

change samples and add a patch method

0342400

adjust tests

d68729b

catalinaperalta reviewed Jul 16, 2024

View reviewed changes

...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py Outdated Show resolved Hide resolved

catalinaperalta reviewed Jul 16, 2024

View reviewed changes

...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py Outdated Show resolved Hide resolved

catalinaperalta reviewed Jul 16, 2024

View reviewed changes

...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py Show resolved Hide resolved

fix tests for radiology insights

c2f85ac

catalinaperalta reviewed Jul 24, 2024

View reviewed changes

- adjust def documentation in patch.py

6761862

- remove unused imports in patch.py - resolve duplicate references in models.py - resolve duplicate and wrong references in README.md

cbovijn reviewed Jul 24, 2024

View reviewed changes

...ealthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_patch.py Show resolved Hide resolved

...althinsights/azure-healthinsights-radiologyinsights/samples/sample_age_mismatch_inference.py Outdated Show resolved Hide resolved

celiabovijn added 4 commits July 24, 2024 17:48

- fix exception handling in samples

de131bd

- move imports in samples - fix pylint and mypy issues in patch files

remove class from sync samples

6274e34

replace deserialize with job iso inference result

- fix bugs sample_finding_inference.py

14c34a4

- fix bugs sample_laterality_discrepancy_inference.py - adjust _operations

undo changes in patch files :

dfaba6d

replace deserialize Job with InferenceResult

catalinaperalta reviewed Jul 29, 2024

View reviewed changes

...insights-radiologyinsights/azure/healthinsights/radiologyinsights/_operations/_operations.py Outdated Show resolved Hide resolved

celiabovijn added 3 commits July 30, 2024 10:06

- revert changes in _operations

d05d9a0

- replace with expected code in _patch

postprocess changes

783902c

revert _patch

350995a

cbovijn requested review from lmazuel, xiangyan99, kristapratico and a team as code owners July 30, 2024 17:08

fix pylint error in _operations.py

fba27a3

fix mypy error in _patch.py (add ignore)

catalinaperalta approved these changes Jul 31, 2024

View reviewed changes

tomsft approved these changes Aug 2, 2024

View reviewed changes

tomsft enabled auto-merge (squash) August 2, 2024 14:19

catalinaperalta disabled auto-merge August 2, 2024 16:36

xiangyan99 approved these changes Aug 2, 2024

View reviewed changes

catalinaperalta merged commit f59f42c into Azure:main Aug 2, 2024
20 checks passed

Radiology insights ga #35276

Radiology insights ga #35276

Uh oh!

Conversation

koen-mertens commented Apr 19, 2024

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

azure-sdk commented Apr 19, 2024

Uh oh!

xiangyan99 commented May 6, 2024

Uh oh!

azure-pipelines bot commented May 6, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

catalinaperalta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cbovijn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

catalinaperalta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

catalinaperalta left a comment •

edited

Loading