[Core] Add start_time kwargs to start_span methods #41106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
requested review from
lmazuel,
annatisch,
johanste,
xiangyan99,
iscai-msft and
kashifkhan
as code owners
There was a problem hiding this comment.
Pull Request Overview
Adds the ability to specify a custom start time when creating spans via the OpenTelemetry tracer.
- Introduce a
start_timekwarg tostart_spanandstart_as_current_span - Update tests to verify spans honor the provided start time
- Document the feature in the CHANGELOG
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/core/azure-core/azure/core/tracing/opentelemetry.py | Added start_time parameter, updated docstrings, and propagated it through context manager |
| sdk/core/azure-core/tests/test_tracer_otel.py | New tests for start_span and start_as_current_span with start_time |
| sdk/core/azure-core/CHANGELOG.md | Recorded the addition of the start_time argument |
kashifkhan
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should expose a
start_timekeyword argument in thestart_spanmethods to allow users to specify the start time of the span. This is useful in scenarios like in SB, where you want to create a span for a receive operation, but also want to add links to the messages that are received, so we want to create the span after the receive operation, but still portray a more accurate duration for the span.