-
Notifications
You must be signed in to change notification settings - Fork 3k
App Config Provider - Tag filters #41148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for tag filters in the App Configuration Provider by expanding the SettingSelector to accept a lists of tag filters and propagating this change through the client managers and async methods. It also fixes a typo ("Reslover" to "Resolver") in secret resolver tests and updates test cases with new tag-based configuration settings.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/testcase.py | Added feature_flag_selectors parameter and new configuration settings with tags. |
tests/test_provider_aad.py | Fixed resolver string typo and added tests for provider tag filters. |
tests/test_provider.py | Fixed resolver string typo and added tests for tag filters with multiple scenarios. |
tests/test_async_provider_aad.py | Fixed resolver string typo and added async tests for tag filters. |
tests/test_async_provider.py | Fixed resolver string typo and added async tests for tag filters. |
tests/asynctestcase.py | Updated async client creation methods to support tag_filters. |
provider/aio/_async_client_manager.py | Propagated tag_filters to the async list_configuration_settings calls. |
provider/_models.py | Updated SettingSelector to accept an optional tag_filters list. |
provider/_client_manager.py | Propagated tag_filters to the synchronous list_configuration_settings calls. |
CHANGELOG.md | Documented the new tag_filters feature in SettingSelector. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_models.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for filtering configuration settings by tags in the App Config provider and updates tests accordingly.
- Extended
SettingSelector
with a newtag_filters
parameter and validation - Updated client managers to pass
tags_filter
tolist_configuration_settings
- Added tagged settings in test utilities and new tests for tag-based selection
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
tests/testcase.py | Added feature_flag_selectors parameter to test clients |
tests/test_setting_selector.py | New tests for tag_filters validation in SettingSelector |
tests/test_provider_aad.py | New AAD provider tests for tag filters |
tests/test_provider.py | New sync provider tests for tag filters |
tests/test_async_provider_aad.py | New async AAD provider tests for tag filters |
tests/test_async_provider.py | New async provider tests for tag filters |
tests/asynctestcase.py | Added feature_flag_selectors to async test clients |
azure/appconfiguration/provider/_models.py | Added tag_filters attribute and validation to SettingSelector |
azure/appconfiguration/provider/_client_manager.py | Pass tags_filter to sync client listing |
azure/appconfiguration/provider/aio/_async_client_manager.py | Pass tags_filter to async client listing |
assets.json | Updated asset tag |
CHANGELOG.md | Documented the new tag_filters feature |
Comments suppressed due to low confidence (1)
sdk/appconfiguration/azure-appconfiguration-provider/tests/test_provider_aad.py:117
- Consider adding
assert "two_tagged" in client
to verify that multi-tagged settings (with taga=b
) are also returned when filtering by a single tag.
assert "tagged_config" in client
Description
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines