work around hang issue in hyper #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As indicated in Azure#1549, there is an issue with hyper (the underlying layer used by reqwest) that hangs in some cases on connection pools. This PR uses a commonly discussed workaround of setting `pool_max_idle_per_host` to 0. Ref: hyperium/hyper#2312
demoray
commented
Jan 5, 2024
| let client = ::reqwest::ClientBuilder::new() | ||
| .pool_max_idle_per_host(0) | ||
| .build() | ||
| .expect("failed to build `reqwest` client"); |
There was a problem hiding this comment.
While I would prefer to not add expect here, this mimics the behavior of reqwest::Client::new(). Moving new_reqwest_client to return a Result cascades into extensive changes.
ctaggart
reviewed
Jan 5, 2024
| // | ||
| // See <https://github.com/hyperium/hyper/issues/2312> for more details. | ||
| let client = ::reqwest::ClientBuilder::new() | ||
| .pool_max_idle_per_host(0) |
There was a problem hiding this comment.
Are there any adverse side effects of setting this?
There was a problem hiding this comment.
It effectively disables connection pools. This has a performance impact but mitigates a client hang.
In addition to the original reporter, I've experienced this issue as well. It's been an open issue in the hyper repo since October 2020.
cataggar
approved these changes
Jan 5, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in #1549, there is an issue with hyper (the underlying layer used by reqwest) that hangs in some cases on connection pools.
This PR uses a commonly discussed workaround of setting
pool_max_idle_per_hostto 0.Ref: hyperium/hyper#2312
Mitigates #1549