Skip to content

Fixed CosmosSqlMetadataProvider concurrency issue. #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Fixed CosmosSqlMetadataProvider concurrency issue. #2695

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51d17e6
Fixed CosmosSqlMetadataProvider concurrency issue.
michaelstaib May 21, 2025
be15010
Merge branch 'main' into mst/fix-2694
Aniruddh25 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/Core/Services/MetadataProviders/CosmosSqlMetadataProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

using System.Collections.Concurrent;
using System.Diagnostics.CodeAnalysis;
using System.IO.Abstractions;
using Azure.DataApiBuilder.Config.DatabasePrimitives;
Expand All @@ -26,7 +27,7 @@ public class CosmosSqlMetadataProvider : ISqlMetadataProvider
private CosmosDbNoSQLDataSourceOptions _cosmosDb;
private readonly RuntimeEntities _runtimeConfigEntities;
private readonly bool _isDevelopmentMode;
private Dictionary<string, string> _partitionKeyPaths = new();
private ConcurrentDictionary<string, string> _partitionKeyPaths = new();

/// <summary>
/// This contains each entity into EDM model convention which will be used to traverse DB Policy filter using ODataParser
Expand Down Expand Up @@ -536,17 +537,21 @@ public IReadOnlyDictionary<string, DatabaseObject> GetEntityNamesAndDbObjects()
/// <inheritdoc />
public string? GetPartitionKeyPath(string database, string container)
{
ArgumentNullException.ThrowIfNull(database);
ArgumentNullException.ThrowIfNull(container);

_partitionKeyPaths.TryGetValue($"{database}/{container}", out string? partitionKeyPath);
return partitionKeyPath;
}

/// <inheritdoc />
public void SetPartitionKeyPath(string database, string container, string partitionKeyPath)
{
if (!_partitionKeyPaths.TryAdd($"{database}/{container}", partitionKeyPath))
{
_partitionKeyPaths[$"{database}/{container}"] = partitionKeyPath;
}
ArgumentNullException.ThrowIfNull(database);
ArgumentNullException.ThrowIfNull(container);
ArgumentNullException.ThrowIfNull(partitionKeyPath);

_partitionKeyPaths.AddOrUpdate($"{database}/{container}", partitionKeyPath, (key, oldValue) => partitionKeyPath);
}

public bool TryGetEntityNameFromPath(string entityPathName, [NotNullWhen(true)] out string? entityName)
Expand Down
Loading